Something went wrong. Try again.
A code review TUI that tries to reduce how many red and green squiggles you have to squint at
Something went wrong. Try again.
thresh cli_test.go
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263package main
import ( "bytes" "context" "os" "path/filepath" "strings" "testing"
"github.com/spf13/cobra"
"secluded.site/thresh/internal/keymap" "secluded.site/thresh/internal/review" "secluded.site/thresh/internal/ui")
func runCLIForTest(t *testing.T, args ...string) (string, string, error) { t.Helper() var stdout bytes.Buffer var stderr bytes.Buffer err := executeCLI(context.Background(), args, &stdout, &stderr) return stdout.String(), stderr.String(), err}
func TestDiffCommandConsumesConfiguredKeymap(t *testing.T) { want := ui.KeymapConfiguration{Review: keymap.Overrides{"quit": {{"x"}}}} command := &diffCommand{} command.configureKeymap(configurationFile{Keymap: &want}) if !equalKeymapOverrides(command.Keymap.Review, want.Review) { t.Fatalf("diff command keymap = %#v, want %#v", command.Keymap, want) }}
func TestCLIHelpUsesStdout(t *testing.T) { stdout, stderr, err := runCLIForTest(t, "--help") if err != nil || !strings.Contains(stdout, "Local-first code review") || stderr != "" { t.Fatalf("executeCLI() = stdout %q, stderr %q, err %v", stdout, stderr, err) }
stdout, stderr, err = runCLIForTest(t, "discussion", "--help") if err != nil || !strings.Contains(stdout, "list") || stderr != "" { t.Fatalf("executeCLI(discussion help) = stdout %q, stderr %q, err %v", stdout, stderr, err) } discussion, _, err := newRootCommand().Find([]string{"discussion"}) if err != nil { t.Fatal(err) } commands := discussion.Commands() if len(commands) != 8 || commands[0].Name() != "create" || commands[1].Name() != "delete" || commands[2].Name() != "edit" || commands[3].Name() != "list" || commands[4].Name() != "reopen" || commands[5].Name() != "reply" || commands[6].Name() != "resolve" || commands[7].Name() != "source" { t.Fatalf("discussion commands = %#v", commands) } if commands[0].Flag("change") == nil || commands[0].Flag("unit") != nil { t.Fatal("discussion create must expose --change instead of --unit") } for _, command := range commands { stdout, stderr, err := runCLIForTest(t, "--agent", "discussion", command.Name(), "--help") if err != nil || stderr != "" || !strings.Contains(stdout, "thresh discussion "+command.Name()) { t.Fatalf("%s help = stdout %q, stderr %q, err %v", command.Name(), stdout, stderr, err) } } _, _, err = runCLIForTest(t, "--agent", "discussion", "reattach", "discussion", "file.go:1") if err == nil || !strings.Contains(err.Error(), "unknown command \"reattach\"") { t.Fatalf("removed reattach command error = %v", err) }}
func TestCLIParseErrorsUseStderr(t *testing.T) { for _, args := range [][]string{{"unknown"}, {"comment", "list"}, {"session", "list"}, {"skill", "--unknown"}} { stdout, stderr, err := runCLIForTest(t, args...) if err == nil || stdout != "" || stderr == "" { t.Fatalf("executeCLI(%v) = stdout %q, stderr %q, err %v", args, stdout, stderr, err) } }}
func TestDiffEnvironmentDefaultsAndShortFlag(t *testing.T) { t.Setenv("THRESH_MODEL", "environment-model") diagnostics := newDiagnosticsOptions() command := newDiffCommand(&diagnostics, newInvocationOptions()) if got := command.Flag("model").DefValue; got != "environment-model" { t.Fatalf("model default = %q", got) } if command.Flag("author") != nil { t.Fatal("diff command retained obsolete --author flag") } if got := command.Flag("change").Shorthand; got != "c" { t.Fatalf("change shorthand = %q", got) } if got := command.Flag("workers").DefValue; got != "3" { t.Fatalf("workers default = %q", got) } if command.Flag("individual") == nil || command.Flag("continuous") == nil { t.Fatal("diff command does not expose both change-view flags") }}
func TestDiffChangeViewFlagsAreMutuallyExclusive(t *testing.T) { _, _, err := runCLIForTest(t, "diff", "--individual", "--continuous") if err == nil || !strings.Contains(err.Error(), "none of the others can be") { t.Fatalf("conflicting change-view flags error = %v", err) }}
func TestDiagnosticFlagsBelongOnlyToDiff(t *testing.T) { root := newRootCommand() diff, _, err := root.Find([]string{"diff"}) if err != nil { t.Fatal(err) } for _, name := range []string{"debug", "log.level", "log.json", "log.path"} { if root.Flag(name) != nil || diff.Flag(name) == nil { t.Fatalf("diagnostic flag %q: root=%v diff=%v", name, root.Flag(name), diff.Flag(name)) } }}
func TestOptionalPositionalsAcceptAtMostOne(t *testing.T) { reviewShow, _, err := newRootCommand().Find([]string{"review", "show"}) if err != nil { t.Fatal(err) } if reviewShow.Flag("json") == nil { t.Fatal("review show must offer explicit JSON output") } discussionList, _, err := newDiscussionCommand(newInvocationOptions()).Find([]string{"list"}) if err != nil { t.Fatal(err) } diagnostics := newDiagnosticsOptions() for _, command := range []*cobra.Command{ newDiffCommand(&diagnostics, newInvocationOptions()), reviewShow, discussionList, } { if err := command.Args(command, nil); err != nil { t.Fatalf("%s rejected omitted positional: %v", command.Name(), err) } if err := command.Args(command, []string{"one"}); err != nil { t.Fatalf("%s rejected one positional: %v", command.Name(), err) } if err := command.Args(command, []string{"one", "two"}); err == nil { t.Fatalf("%s accepted two positionals", command.Name()) } }}
func TestInvocationIdentityIsExplicitAndModeAware(t *testing.T) { t.Setenv("USER", "Ignored Environment User") unsetTestEnvironment(t, "THRESH_IDENTITY") options := newInvocationOptions() options.configurationPath = filepath.Join(t.TempDir(), "config.toml") human, err := options.resolveActor(false) if err != nil || human.actor.Kind != review.ActorHuman || human.actor.Name != "user" || human.configured { t.Fatalf("default human actor = %#v, %v", human, err) } options.agent = true agent, err := options.resolveActor(false) if err != nil || agent.actor.Kind != review.ActorAgent || agent.actor.Name != "agent" || !agent.configured { t.Fatalf("default agent actor = %#v, %v", agent, err) }
t.Setenv("THRESH_IDENTITY", "Environment Identity") environment, err := newInvocationOptions().actor(false) if err != nil || environment.Name != "Environment Identity" { t.Fatalf("environment actor = %#v, %v", environment, err) } flag, err := (invocationOptions{ identity: "Flag Identity", identityEnvironment: true, }).actor(true) if err != nil || flag.Name != "Flag Identity" { t.Fatalf("flag actor = %#v, %v", flag, err) } if _, err := (invocationOptions{}).actor(true); err == nil { t.Fatal("explicit empty identity was accepted") }
if err := saveConfiguredIdentity(options.configurationPath, "Saved Identity"); err != nil { t.Fatal(err) } options.agent = false saved, err := options.resolveActor(false) if err != nil || saved.actor.Kind != review.ActorHuman || saved.actor.Name != "Saved Identity" || !saved.configured { t.Fatalf("saved human actor = %#v, %v", saved, err) } options.agent = true savedAgent, err := options.actor(false) if err != nil || savedAgent.Kind != review.ActorAgent || savedAgent.Name != "agent" { t.Fatalf("saved identity leaked into agent actor = %#v, %v", savedAgent, err) }}
func unsetTestEnvironment(t *testing.T, name string) { t.Helper() prior, existed := os.LookupEnv(name) if err := os.Unsetenv(name); err != nil { t.Fatal(err) } t.Cleanup(func() { if existed { if err := os.Setenv(name, prior); err != nil { t.Errorf("restore %s: %v", name, err) } return } if err := os.Unsetenv(name); err != nil { t.Errorf("clear %s: %v", name, err) } })}
func TestFangActionOutputUsesStdout(t *testing.T) { for _, args := range [][]string{{"skill"}, {"--agent", "skill"}, {"skill", "--agent"}} { stdout, stderr, err := runCLIForTest(t, args...) if err != nil || stdout != threshSkill || stderr != "" { t.Fatalf("executeCLI(%v) = stdout length %d, stderr %q, err %v", args, len(stdout), stderr, err) } }}
func TestFangProvidesVersionAndCompletionCommands(t *testing.T) { stdout, stderr, err := runCLIForTest(t, "--version") if err != nil || !strings.Contains(stdout, "thresh version") || stderr != "" { t.Fatalf("version = stdout %q, stderr %q, err %v", stdout, stderr, err) } stdout, stderr, err = runCLIForTest(t, "completion", "bash") if err != nil || !strings.Contains(stdout, "__start_thresh") || !strings.Contains(stdout, "complete -o default") || stderr != "" { t.Fatalf("completion = stdout %q, stderr %q, err %v", stdout, stderr, err) }}
func TestFangLoggingFlagsConfigureDiffDiagnostics(t *testing.T) { path := filepath.Join(t.TempDir(), "thresh.log") secret := "must-not-appear-in-diagnostics" t.Setenv("OPENAI_API_KEY", secret) stdout, stderr, runErr := runCLIForTest( t, "--identity", "user", "diff", "--debug", "--log.path", path, "--vcs", "invalid", ) if runErr == nil || stdout != "" || stderr == "" { t.Fatalf("invalid diff = stdout %q, stderr %q, error %v", stdout, stderr, runErr) } content, err := os.ReadFile(path) if err != nil { t.Fatal(err) } if !strings.Contains(string(content), "diagnostics initialized") || !strings.Contains(string(content), "diff command failed") || !strings.Contains(string(content), "vcs must be one of git, jj, or hg") || strings.Contains(string(content), secret) { t.Fatalf("diagnostic log = %q", content) }}