From 37713a9f0657de995f0f1004e116e64be789400a Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Sat, 30 Aug 2025 11:14:44 +0200 Subject: [PATCH] Icons: Remove duplicate icon names from PHUIIconExample Summary: http://phorge.localhost/uiexample/view/PHUIIconExample/ lists `fa-git` and `fa-hacker-news` twice. (I only refer to duplicate _names_. Duplicate _icons_ due to name aliases is a different topic.) `PHUIIconView::getIcons()` is to blame for that content. Remove these two duplicate name entries. Test Plan: Look at http://phorge.localhost/uiexample/view/PHUIIconExample/ and search for `fa-git` and `fa-hacker-news`. Reviewers: O1 Blessed Committers, mainframe98 Reviewed By: O1 Blessed Committers, mainframe98 Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D26303 --- src/view/phui/PHUIIconView.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/view/phui/PHUIIconView.php b/src/view/phui/PHUIIconView.php index 5a6bba71b1..d0326eb538 100644 --- a/src/view/phui/PHUIIconView.php +++ b/src/view/phui/PHUIIconView.php @@ -596,7 +596,6 @@ final class PHUIIconView extends AphrontTagView { 'fa-empire', 'fa-git-square', 'fa-git', - 'fa-hacker-news', 'fa-tencent-weibo', 'fa-qq', 'fa-wechat', @@ -696,7 +695,6 @@ final class PHUIIconView extends AphrontTagView { 'fa-train', 'fa-subway', 'fa-medium', - 'fa-git', 'fa-y-combinator-square', 'fa-yc-square', 'fa-hacker-news', -- knotmirror 0.0.1