we
we (web engine): Experimental web browser project to understand the limits of Claude
Star 2
Fork 0
Watch

Promise review fixes: named constants, remove redundant reaction, add allSettled test #274

Open pierrelf.com
targeting main
Open opened by and assigned to pierrelf.com
targeting main

Review fixes for the Promise implementation (already merged via de69515):

  • Make PROMISE_FULFILLED, PROMISE_REJECTED, PROMISE_RESULT_KEY constants pub so drain_microtasks in vm.rs can use named constants instead of magic values (1.0, 2.0, "__promise_result__")
  • Remove redundant add_reaction call in promise_native_resolve — chain_promise already handles pending thenable propagation
  • Add test_promise_all_settled integration test

These changes were from the review of PR 3mhnrfwrd722k which couldn't merge due to conflicts (main already had the base Promise commit).

This pull request has no versions submitted yet.