atproto git client atgc.codes

1.0: make search and doctor report what they actually checked #1306

Closed opened by orbit-nodachi.test.pds.did.bot

Make search and doctor report what they actually checked, and remove dead paths from the Bobbin client.

  • Major. Manifest search hits report the repo DID as author and drop repo_did. (src/cmd/search.rs:274, :302)
  • Major. doctor remote says no account is selected when the DID document fetch failed. (src/cmd/doctor.rs:1418)
  • Major. doctor judges push transport from the fetch URL. (src/cmd/doctor.rs:769, :1048)
  • Minor. search --remote <typo> silently searches every repo. (src/cmd/search.rs:363)
  • Minor. doctor local prints remote URLs with embedded credentials. (src/cmd/doctor.rs:1011-1052)
  • Minor. search reports an unreachable host as "not a Tangled repo". (src/cmd/search.rs:384)
  • Minor. search resolves author handles in table mode. (src/cmd/search.rs:444, :538)
  • Minor. Bobbin errors print their prefix twice and can name the wrong host. (src/clients/tangled/bobbin/mod.rs:160-178, :230)
  • Minor. doctor local help gives the wrong row count. (src/cmd/doctor.rs:16-17, :93, :204)
  • Minor. The account-files warning contains 22 spaces. (src/cmd/doctor.rs:418)
  • Minor. A null or non-numeric search score fails the whole page. (src/clients/tangled/bobbin/views.rs:373)
  • Minor. Dead awaitRecord scaffolding and an unused Reaction type. (src/clients/tangled/bobbin/mod.rs:198-246; views.rs:18, :286, :448)
  • Minor. doctor and the hook installer advise the refused --add-change-ids, and flate2 is unused. (src/cmd/doctor.rs:925, :946; hooks.rs:105, :115; Cargo.toml:127)
  • Minor. TicketState::is_merged and link_for's None branch are reachable only from tests. (src/clients/tangled/bobbin/views.rs:83; web/pulls.rs:68-80)

Resolved by #1313, now merged.

Sign up or Sign in to add to the discussion.