Something went wrong. Try again.
A lexicon-driven AppView for ATProto. forked from gamesgamesgamesgames.games/happyview
Something went wrong. Try again.
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556use axum::Json;use axum::extract::{Path, Query, State};use axum::http::StatusCode;use hex;use rand::Rng;use serde::Deserialize;use sha2::{Digest, Sha256};use sqlx::Row;use uuid::Uuid;
use crate::AppState;use crate::db::{adapt_sql, now_rfc3339};use crate::error::AppError;use crate::event_log::{EventLog, Severity, log_event};
use super::auth::UserAuth;use super::permissions::Permission;use super::types::{ ApiClientSummary, CreateApiClientBody, CreateApiClientResponse, UpdateApiClientBody,};
#[derive(Deserialize)]pub(super) struct ListApiClientsQuery { pub(super) parent_id: Option<String>,}
/// POST /admin/api-clients — create a new API client.pub(super) async fn create_api_client( State(state): State<AppState>, auth: UserAuth, Json(body): Json<CreateApiClientBody>,) -> Result<(StatusCode, Json<CreateApiClientResponse>), AppError> { auth.require(Permission::ApiClientsCreate).await?;
// Generate the client key: "hvc_" + 32 random hex chars. let mut random_bytes = [0u8; 16]; rand::rng().fill(&mut random_bytes); let client_key = format!("hvc_{}", hex::encode(random_bytes));
// Generate the client secret for confidential clients only. let (client_secret, client_secret_hash) = if body.client_type == "confidential" { let mut secret_bytes = [0u8; 32]; rand::rng().fill(&mut secret_bytes); let secret = format!("hvs_{}", hex::encode(secret_bytes)); let hash = hex::encode(Sha256::digest(secret.as_bytes())); (Some(secret), hash) } else { (None, String::new()) };
let id = Uuid::new_v4().to_string(); let now = now_rfc3339(); let redirect_uris_json = serde_json::to_string(&body.redirect_uris).unwrap_or_else(|_| "[]".to_string());
let allowed_origins_json = body .allowed_origins .as_ref() .map(|origins| serde_json::to_string(origins).unwrap_or_else(|_| "[]".to_string()));
let insert_sql = adapt_sql( "INSERT INTO api_clients (id, client_key, client_secret_hash, name, client_id_url, client_uri, redirect_uris, scopes, rate_limit_capacity, rate_limit_refill_rate, client_type, allowed_origins, is_active, created_by, created_at, updated_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 1, ?, ?, ?)", state.db_backend, );
sqlx::query(&insert_sql) .bind(&id) .bind(&client_key) .bind(&client_secret_hash) .bind(&body.name) .bind(&body.client_id_url) .bind(&body.client_uri) .bind(&redirect_uris_json) .bind(&body.scopes) .bind(body.rate_limit_capacity) .bind(body.rate_limit_refill_rate) .bind(&body.client_type) .bind(&allowed_origins_json) .bind(&auth.did) .bind(&now) .bind(&now) .execute(&state.db) .await .map_err(|e| AppError::Internal(format!("failed to create api client: {e}")))?;
// Register the new client in the OAuth registry so it's usable immediately. let oauth_params = crate::auth::client_registry::ApiClientOAuthParams { plc_url: state.config.plc_url.clone(), state_store: state.oauth_state_store.clone(), session_store_pool: state.db.clone(), db_backend: state.db_backend, }; if let Err(e) = state.oauth.register_api_client( &body.client_id_url, &body.client_uri, body.redirect_uris.clone(), &body.scopes, &oauth_params, ) { tracing::warn!(client_id = %body.client_id_url, error = %e, "OAuth client registration failed (DB row created)"); }
// Register the client identity for request validation. state.rate_limiter.register_client_identity( client_key.clone(), crate::rate_limit::ClientIdentity { secret_hash: client_secret_hash.clone(), client_uri: body.client_uri.clone(), }, );
// Register per-client rate limit config if overrides are set. if let (Some(capacity), Some(refill_rate)) = (body.rate_limit_capacity, body.rate_limit_refill_rate) { let defaults = state.rate_limiter.defaults(); state.rate_limiter.register_client_config( client_key.clone(), crate::rate_limit::RateLimitConfig { capacity: capacity as u32, refill_rate, default_query_cost: defaults.query_cost, default_procedure_cost: defaults.procedure_cost, default_proxy_cost: defaults.proxy_cost, }, ); }
log_event( &state.db, EventLog { event_type: "api_client.created".to_string(), severity: Severity::Info, actor_did: Some(auth.did.clone()), subject: Some(body.name.clone()), detail: serde_json::json!({ "client_key": client_key, "client_id_url": body.client_id_url, }), }, state.db_backend, ) .await;
Ok(( StatusCode::CREATED, Json(CreateApiClientResponse { id, client_key, client_secret, name: body.name, client_id_url: body.client_id_url, client_type: body.client_type, }), ))}
/// GET /admin/api-clients — list all API clients.pub(super) async fn list_api_clients( State(state): State<AppState>, auth: UserAuth, Query(query): Query<ListApiClientsQuery>,) -> Result<Json<Vec<ApiClientSummary>>, AppError> { auth.require(Permission::ApiClientsView).await?;
let (select_sql, parent_filter) = if let Some(ref parent_id) = query.parent_id { ( adapt_sql( "SELECT id, client_key, name, client_id_url, client_uri, redirect_uris, scopes, client_type, allowed_origins, rate_limit_capacity, rate_limit_refill_rate, is_active, created_by, created_at, updated_at, parent_client_id, owner_did FROM api_clients WHERE parent_client_id = ? ORDER BY created_at DESC", state.db_backend, ), Some(parent_id.clone()), ) } else { ( adapt_sql( "SELECT id, client_key, name, client_id_url, client_uri, redirect_uris, scopes, client_type, allowed_origins, rate_limit_capacity, rate_limit_refill_rate, is_active, created_by, created_at, updated_at, parent_client_id, owner_did FROM api_clients ORDER BY created_at DESC", state.db_backend, ), None, ) };
let q = sqlx::query(&select_sql); let q = if let Some(ref pid) = parent_filter { q.bind(pid) } else { q };
let rows = q .fetch_all(&state.db) .await .map_err(|e| AppError::Internal(format!("failed to list api clients: {e}")))?;
let clients: Vec<ApiClientSummary> = rows .into_iter() .map(|row| { let redirect_uris_json: String = row.get("redirect_uris"); let allowed_origins_json: Option<String> = row.get("allowed_origins"); let is_active: i32 = row.get("is_active"); let redirect_uris: Vec<String> = serde_json::from_str(&redirect_uris_json).unwrap_or_default(); let allowed_origins: Option<Vec<String>> = allowed_origins_json .as_deref() .and_then(|j| serde_json::from_str(j).ok()); ApiClientSummary { id: row.get("id"), client_key: row.get("client_key"), name: row.get("name"), client_id_url: row.get("client_id_url"), client_uri: row.get("client_uri"), redirect_uris, scopes: row.get("scopes"), client_type: row.get("client_type"), allowed_origins, rate_limit_capacity: row.get("rate_limit_capacity"), rate_limit_refill_rate: row.get("rate_limit_refill_rate"), is_active: is_active != 0, created_by: row.get("created_by"), created_at: row.get("created_at"), updated_at: row.get("updated_at"), parent_client_id: row.get("parent_client_id"), owner_did: row.get("owner_did"), } }) .collect();
Ok(Json(clients))}
/// GET /admin/api-clients/:id — get a single API client.pub(super) async fn get_api_client( State(state): State<AppState>, auth: UserAuth, Path(id): Path<String>,) -> Result<Json<ApiClientSummary>, AppError> { auth.require(Permission::ApiClientsView).await?;
let select_sql = adapt_sql( "SELECT id, client_key, name, client_id_url, client_uri, redirect_uris, scopes, client_type, allowed_origins, rate_limit_capacity, rate_limit_refill_rate, is_active, created_by, created_at, updated_at, parent_client_id, owner_did FROM api_clients WHERE id = ?", state.db_backend, );
let row = sqlx::query(&select_sql) .bind(&id) .fetch_optional(&state.db) .await .map_err(|e| AppError::Internal(format!("failed to get api client: {e}")))?;
let Some(row) = row else { return Err(AppError::NotFound(format!("api client '{id}' not found"))); };
let redirect_uris_json: String = row.get("redirect_uris"); let allowed_origins_json: Option<String> = row.get("allowed_origins"); let is_active: i32 = row.get("is_active"); let redirect_uris: Vec<String> = serde_json::from_str(&redirect_uris_json).unwrap_or_default(); let allowed_origins: Option<Vec<String>> = allowed_origins_json .as_deref() .and_then(|j| serde_json::from_str(j).ok());
Ok(Json(ApiClientSummary { id: row.get("id"), client_key: row.get("client_key"), name: row.get("name"), client_id_url: row.get("client_id_url"), client_uri: row.get("client_uri"), redirect_uris, scopes: row.get("scopes"), client_type: row.get("client_type"), allowed_origins, rate_limit_capacity: row.get("rate_limit_capacity"), rate_limit_refill_rate: row.get("rate_limit_refill_rate"), is_active: is_active != 0, created_by: row.get("created_by"), created_at: row.get("created_at"), updated_at: row.get("updated_at"), parent_client_id: row.get("parent_client_id"), owner_did: row.get("owner_did"), }))}
/// PUT /admin/api-clients/:id — update an API client.pub(super) async fn update_api_client( State(state): State<AppState>, auth: UserAuth, Path(id): Path<String>, Json(body): Json<UpdateApiClientBody>,) -> Result<StatusCode, AppError> { auth.require(Permission::ApiClientsEdit).await?;
// Read current values let select_sql = adapt_sql( "SELECT client_key, client_secret_hash, name, client_id_url, client_uri, redirect_uris, scopes, allowed_origins, rate_limit_capacity, rate_limit_refill_rate, is_active FROM api_clients WHERE id = ?", state.db_backend, );
type UpdateRow = ( String, String, String, String, String, String, String, Option<String>, Option<i32>, Option<f64>, i32, ); let row: Option<UpdateRow> = sqlx::query_as(&select_sql) .bind(&id) .fetch_optional(&state.db) .await .map_err(|e| AppError::Internal(format!("failed to get api client: {e}")))?;
let Some(( client_key, client_secret_hash, cur_name, client_id_url, cur_client_uri, cur_redirect_uris, cur_scopes, cur_allowed_origins, cur_capacity, cur_refill, cur_active, )) = row else { return Err(AppError::NotFound(format!("api client '{id}' not found"))); };
let name = body.name.unwrap_or(cur_name); let client_uri = body.client_uri.unwrap_or(cur_client_uri); let redirect_uris_json = body .redirect_uris .map(|uris| serde_json::to_string(&uris).unwrap_or_else(|_| "[]".to_string())) .unwrap_or(cur_redirect_uris); let scopes = body.scopes.unwrap_or(cur_scopes); let allowed_origins_json: Option<String> = match body.allowed_origins { Some(Some(origins)) => { Some(serde_json::to_string(&origins).unwrap_or_else(|_| "[]".to_string())) } Some(None) => None, None => cur_allowed_origins, }; let capacity = body.rate_limit_capacity.unwrap_or(cur_capacity); let refill_rate = body.rate_limit_refill_rate.unwrap_or(cur_refill); let is_active = body .is_active .map(|a| if a { 1i32 } else { 0i32 }) .unwrap_or(cur_active); let now = now_rfc3339();
let update_sql = adapt_sql( "UPDATE api_clients SET name = ?, client_uri = ?, redirect_uris = ?, scopes = ?, allowed_origins = ?, rate_limit_capacity = ?, rate_limit_refill_rate = ?, is_active = ?, updated_at = ? WHERE id = ?", state.db_backend, );
sqlx::query(&update_sql) .bind(&name) .bind(&client_uri) .bind(&redirect_uris_json) .bind(&scopes) .bind(&allowed_origins_json) .bind(capacity) .bind(refill_rate) .bind(is_active) .bind(&now) .bind(&id) .execute(&state.db) .await .map_err(|e| AppError::Internal(format!("failed to update api client: {e}")))?;
// Re-register or remove from OAuth registry based on active status. let oauth_params = crate::auth::client_registry::ApiClientOAuthParams { plc_url: state.config.plc_url.clone(), state_store: state.oauth_state_store.clone(), session_store_pool: state.db.clone(), db_backend: state.db_backend, }; if is_active != 0 { let redirect_uris: Vec<String> = serde_json::from_str(&redirect_uris_json).unwrap_or_default(); if let Err(e) = state.oauth.register_api_client( &client_id_url, &client_uri, redirect_uris, &scopes, &oauth_params, ) { tracing::warn!(client_id = %client_id_url, error = %e, "OAuth client re-registration failed"); } } else { state.oauth.remove(&client_id_url); }
// Update client identity and per-client rate limit config. if is_active != 0 { state.rate_limiter.register_client_identity( client_key.clone(), crate::rate_limit::ClientIdentity { secret_hash: client_secret_hash, client_uri: client_uri.clone(), }, ); if let (Some(cap), Some(refill)) = (capacity, refill_rate) { let defaults = state.rate_limiter.defaults(); state.rate_limiter.register_client_config( client_key, crate::rate_limit::RateLimitConfig { capacity: cap as u32, refill_rate: refill, default_query_cost: defaults.query_cost, default_procedure_cost: defaults.procedure_cost, default_proxy_cost: defaults.proxy_cost, }, ); } else { // Rate limit overrides were cleared — remove per-client config. state.rate_limiter.remove_client_config(&client_key); } } else { state.rate_limiter.remove_client_identity(&client_key); state.rate_limiter.remove_client_config(&client_key);
// Cascade deactivation to child clients. let deactivate_children_sql = adapt_sql( "UPDATE api_clients SET is_active = 0, updated_at = ? WHERE parent_client_id = ? AND is_active = 1", state.db_backend, ); let _ = sqlx::query(&deactivate_children_sql) .bind(&now) .bind(&id) .execute(&state.db) .await;
let children_sql = adapt_sql( "SELECT client_id_url, client_key FROM api_clients WHERE parent_client_id = ?", state.db_backend, ); if let Ok(children) = sqlx::query_as::<_, (String, String)>(&children_sql) .bind(&id) .fetch_all(&state.db) .await { for (child_url, child_key) in children { state.oauth.remove(&child_url); state.rate_limiter.remove_client_config(&child_key); state.rate_limiter.remove_client_identity(&child_key); } } }
log_event( &state.db, EventLog { event_type: "api_client.updated".to_string(), severity: Severity::Info, actor_did: Some(auth.did.clone()), subject: Some(id), detail: serde_json::json!({}), }, state.db_backend, ) .await;
Ok(StatusCode::NO_CONTENT)}
/// DELETE /admin/api-clients/:id — delete an API client.pub(super) async fn delete_api_client( State(state): State<AppState>, auth: UserAuth, Path(id): Path<String>,) -> Result<StatusCode, AppError> { auth.require(Permission::ApiClientsDelete).await?;
// Look up client_id_url and client_key before deleting so we can remove from registries. let lookup_sql = adapt_sql( "SELECT client_id_url, client_key FROM api_clients WHERE id = ?", state.db_backend, ); let client_info: Option<(String, String)> = sqlx::query_as(&lookup_sql) .bind(&id) .fetch_optional(&state.db) .await .map_err(|e| AppError::Internal(format!("failed to look up api client: {e}")))?;
// Look up child clients before deleting (ON DELETE CASCADE will remove DB rows). let children_sql = adapt_sql( "SELECT client_id_url, client_key FROM api_clients WHERE parent_client_id = ?", state.db_backend, ); let children: Vec<(String, String)> = sqlx::query_as(&children_sql) .bind(&id) .fetch_all(&state.db) .await .unwrap_or_default();
let delete_sql = adapt_sql("DELETE FROM api_clients WHERE id = ?", state.db_backend);
let result = sqlx::query(&delete_sql) .bind(&id) .execute(&state.db) .await .map_err(|e| AppError::Internal(format!("failed to delete api client: {e}")))?;
if result.rows_affected() == 0 { return Err(AppError::NotFound(format!("api client '{id}' not found"))); }
// Remove parent from OAuth registry, rate limiter, and client identities. if let Some((url, key)) = client_info { state.oauth.remove(&url); state.rate_limiter.remove_client_config(&key); state.rate_limiter.remove_client_identity(&key); }
// Remove child clients from in-memory registries (DB rows already cascaded). for (child_url, child_key) in &children { state.oauth.remove(child_url); state.rate_limiter.remove_client_config(child_key); state.rate_limiter.remove_client_identity(child_key); }
log_event( &state.db, EventLog { event_type: "api_client.deleted".to_string(), severity: Severity::Info, actor_did: Some(auth.did.clone()), subject: Some(id), detail: serde_json::json!({}), }, state.db_backend, ) .await;
Ok(StatusCode::NO_CONTENT)}
#[cfg(test)]mod tests { #[test] fn test_client_key_prefix() { let mut random_bytes = [0u8; 16]; rand::Rng::fill(&mut rand::rng(), &mut random_bytes); let key = format!("hvc_{}", hex::encode(random_bytes)); assert!(key.starts_with("hvc_")); assert_eq!(key.len(), 4 + 32); // "hvc_" + 32 hex chars }}