From a9ab3334b0804c2dbdb1dfd1aa005c77ff4d30e6 Mon Sep 17 00:00:00 2001 From: Evgeni Chasnovski Date: Thu, 29 May 2025 15:46:13 +0300 Subject: [PATCH] fix(pick): update `set_picker_query` to not have side effects Resolve #1833 --- lua/mini/pick.lua | 2 +- tests/test_pick.lua | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/lua/mini/pick.lua b/lua/mini/pick.lua index 2c339159..a48cead9 100644 --- a/lua/mini/pick.lua +++ b/lua/mini/pick.lua @@ -1815,7 +1815,7 @@ MiniPick.set_picker_query = function(query) if not MiniPick.is_picker_active() then return end if not H.is_array_of(query, 'string') then H.error('`query` should be an array of strings.') end - H.pickers.active.query, H.pickers.active.caret = query, #query + 1 + H.pickers.active.query, H.pickers.active.caret = vim.deepcopy(query), #query + 1 H.querytick = H.querytick + 1 H.pickers.active.match_inds = H.seq_along(MiniPick.get_picker_items()) H.picker_update(H.pickers.active, true) diff --git a/tests/test_pick.lua b/tests/test_pick.lua index 98f9f762..fadbb5d4 100644 --- a/tests/test_pick.lua +++ b/tests/test_pick.lua @@ -4490,6 +4490,18 @@ T['set_picker_query()']['works'] = function() eq(set_picker_query({ 'a' }), vim.NIL) end +T['set_picker_query()']['does not have side effects'] = function() + start_with_items({ 'a', 'b', 'bb' }) + + child.lua([[ + _G.query = { 'b' } + MiniPick.set_picker_query(_G.query) + ]]) + + type_keys('b') + eq(child.lua_get('_G.query'), { 'b' }) +end + T['set_picker_query()']['resets caret'] = function() start_with_items({ 'a', 'b', 'bb' }) type_keys('b', 'b', '') -- knotmirror 0.0.1