atproto made easy crates.io/crates/jacquard

`PlcSource::Slingshot` fails due to invalid URL #39

Closed boltless.me
Closed opened by boltless.me
assigned to nonbinary.computer

crates/jacquard-identity/src/lib.rs:876-878

let url_str = match &self.opts.plc_source {
    PlcSource::PlcDirectory { base } => {
        // this is odd, the join screws up with the plc directory but NOT slingshot
        format!("{}{}", base, did.as_str())
    }
    PlcSource::Slingshot { base } => {
        format!("{}{}", base, did.as_str())
    }
};

afaik slingshot doesn't support any non-xrpc APIs, so format!("{}{}", base, did.as_str()) here definitely seems wrong. Using slingshot as PLC source will always fail with 404 NotFound. But I'm bit confused because this code has been there for quite a while.

Is this a bug or is there some hidden spec I missed?

hmmm. possible just a longstanding bug i missed. will look into it, thanks

yep, was a bug. should be fixed now on main, uses the miniDoc endpoint. Might add some docs before release.

Sign up or Sign in to add to the discussion.