commits
i think i broke this a while ago when trying to get the favicon to work oops
🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️
it's *fine* but i don't think it's guaranteed that serde_json will round-trip the object structure exactly, and that might even be unlikely.
in general this shouldn't be a problem, since logs will still be exactly verifiable compared to upstream by canonicalizing into dag-cbor etc, but that's annoying.
leaving it for now but once we get there, we can:
- keep a copy of the original string beside the op (~2x memory? probably fine?) or
- use some rust trickery to let us keep the original string and put the parsed thing as a referencing struct next to it. (oroborus etc)
it's *fine* but i don't think it's guaranteed that serde_json will round-trip the object structure exactly, and that might even be unlikely.
in general this shouldn't be a problem, since logs will still be exactly verifiable compared to upstream by canonicalizing into dag-cbor etc, but that's annoying.
leaving it for now but once we get there, we can:
- keep a copy of the original string beside the op (~2x memory? probably fine?) or
- use some rust trickery to let us keep the original string and put the parsed thing as a referencing struct next to it. (oroborus etc)