julien.rbrt.fr / tangled-core
forked from tangled.org/core
Monorepo for Tangled — https://tangled.org
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

appview: pulls: fix commit links in format-patch submissions

the conditionals here were a bit confusing, branch-based PRs just
skipped commit links altogether.

oppi.li 231d9a76 8a571743

+11 -10
+11 -10
appview/pages/templates/repo/pulls/pull.html
··· 88 <div class="flex items-center gap-2"> 89 {{ i "git-commit-horizontal" "w-4 h-4" }} 90 <div class="text-sm text-gray-500 dark:text-gray-400"> 91 - {{ if not $.Pull.IsPatchBased }} 92 - {{ $fullRepo := $.RepoInfo.FullName }} 93 - {{ if $.Pull.IsForkBased }} 94 - {{ if $.Pull.PullSource.Repo }} 95 - {{ $fullRepo = printf "%s/%s" $owner $.Pull.PullSource.Repo.Name }} 96 - <a href="/{{ $fullRepo }}/commit/{{ .SHA }}" class="font-mono text-gray-500 dark:text-gray-400">{{ slice .SHA 0 8 }}</a> 97 - {{ else }} 98 - <span class="font-mono">{{ slice .SHA 0 8 }}</span> 99 - {{ end }} 100 - {{ end }} 101 {{ else }} 102 <span class="font-mono">{{ slice .SHA 0 8 }}</span> 103 {{ end }}
··· 88 <div class="flex items-center gap-2"> 89 {{ i "git-commit-horizontal" "w-4 h-4" }} 90 <div class="text-sm text-gray-500 dark:text-gray-400"> 91 + <!-- attempt to resolve $fullRepo: this is possible only on non-deleted forks and branches --> 92 + {{ $fullRepo := "" }} 93 + {{ if and $.Pull.IsForkBased $.Pull.PullSource.Repo }} 94 + {{ $fullRepo = printf "%s/%s" $owner $.Pull.PullSource.Repo.Name }} 95 + {{ else if $.Pull.IsBranchBased }} 96 + {{ $fullRepo = $.RepoInfo.FullName }} 97 + {{ end }} 98 + 99 + <!-- if $fullRepo was resolved, link to it, otherwise just span without a link --> 100 + {{ if $fullRepo }} 101 + <a href="/{{ $fullRepo }}/commit/{{ .SHA }}" class="font-mono text-gray-500 dark:text-gray-400">{{ slice .SHA 0 8 }}</a> 102 {{ else }} 103 <span class="font-mono">{{ slice .SHA 0 8 }}</span> 104 {{ end }}