commits
Testing with and without LVS_AUTOARRANGE with tile view and icon
mode show it behaves identically (as far as I can tell). So reuse
that logic.
I've introduced a few helpers like is_icon_like to make this easier.
Testing confirmed that the data is copied into the list view and can
be discarded by the caller. Docs showed that the list view writes into
the caller position, and doesn't change the pointer value.
Interestingly, when a callback is used, the listview allocates to
place the data, probably to not "split" ownership or double allocate.
JIRA issue: CORE-20499
On many Intel Macs and likely other EFI 1.x devices, allocating
the disk buffer with AllocatePool fails with `EFI_OUT_OF_RESOURCES`.
This causes FreeLoader hardware detection failure on Macs.
Workaround this issue by allocating with `MmAllocateMemoryWithType`
if `AllocatePool` via Boot Services fails.
CORE-11954
Implement the Alt+Numpad method for inserting characters with their
OEM (Alt+xxx) or their current ANSI codepage (Alt+0xxx) codes.
CORE-5680
For reference, see:
- https://en.wikipedia.org/wiki/Alt_code
- https://devblogs.microsoft.com/oldnewthing/20240702-00/?p=109951
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
The test used the obsolete CRT. The test doesn't provide much value anyway, because we test all the used code already through msvcrt_apitest, ntdll_apitest, etc. The only real benefit was testing and working outside of reactos.
I kept the build file around, which could be revived with msvcrt_static or libcntpr, but that needs some work.
_chkesp is already part of vcruntime library.
CORE-18122
- Check if `EntriesCount` can overflow the required memory size.
- Add an apitest for `NtUserCreateAcceleratorTable`.
Don't show deleted wallpaper.
JIRA issue: CORE-19896
- Check the return value of SHGetFileInfoW of
AddListViewItems function in background.c.
- Fix icon handle leak.
Co-authored-by: Adam Słaboń <asaillen@protonmail.com>
Update translations for:
- EVENTVWR, MSPAINT, NOTEPAD, RAPPS, REGEDIT, TASKMGR;
- IPCONFIG, TRACERT, WLANCONF.
CORE-20207
Co-authored-by: Adam Słaboń <asaillen@protonmail.com>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
- Move common partition creation code to a separate function.
* [UEFILDR][FREELDR] Don't let LoaderPangesSpanned span half of mem space
* [FREELDR][UEFILDR] Fix x64 ABI Violations
Fix incorrect $ATTRIBUTE_LIST parsing on NTFS driver of FreeLdr.
JIRA issue: CORE-17311
- Minor refactoring.
- Use PostMessageW for
WM_SETTINGCHANGE and
WM_FONTCHANGE notification
instead of SendMessageTimeoutW.
- Delete IDS_COL_ATTR_LETTERS
resource string.
All strings have been translated and reviewed for clarity, grammar,
and consistency with the existing Croatian translations used in ReactOS.
Follow-up of #8639. Our <shlobj.h> has already SHMultiFileProperties prototype.
CORE-17311
* [KERNEL32] Split off some ANSI functions from the bulk of Kernel32
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Update translation for KBSWITCH, and the following CPL applets:
DESK, HOTPLUG, INPUT, MMSYS, POWERCFG, SYSDM.
- Add SHELLEXT Cabview Indonesian translation.
- Add SHELLEXT Cryptext Indonesian translation.
- Update CPL Appwiz Indonesian translation.
- Update CPL Desk Indonesian translation.
- Update CPL Hotplug Indonesian translation.
- Add an explicit rule to not make unsubstantiated claims, especially regarding undermining the project.
- Adjusted formatting.
Improve usability of Fonts folder.
JIRA issue: CORE-17311
- Modify PIDL design to contain
name and filename.
- Implement CFontExt::
ParseDisplayName to parsing
name as PIDL.
- Modify CDefaultContextMenu::
GetCommandString and
CDefaultContextMenu::
DoCopyOrCut for DFM_GETVERBA,
DFM_GETVERBW, DFM_CMD_COPY,
and DFM_CMD_MOVE.
- Add IDS_CONFIRM_DELETE_FONT,
IDS_CANTDELETEFONT, and
IDS_PROPERTIES resource strings.
- Add SHMultiFileProperties
prototype to <shlobj.h>.
* [SDK][BOOT] Reimport the EDK2 headers
* [ENVIRON] Remove Environ
- Pass the output buffer size to the PrintSize function.
- Use StringCchPrintfW instead of swprintf.
Follow-up of #8632. Improve usability of ZIP Folder.
JIRA issue: CORE-20464
- Add IDS_CONFIRMDELETE_TEXT and
IDS_CANTDELETEFILE resource strings.
- When deleting files in Zip Folder, create a
temporary file.
- CZipFolder::CopyZipEntry adds files to the
temporary file without adding files to delete.
- Replacing the target ZIP file with the temporary
file implements deleting files in Zip Folder.
- Add SFGAO_CANDELETE attribute.
- Add DFM_CMD_DELETE action.
- Modify CDefaultContextMenu in shell32 to invoke DFM_CMD_DELETE etc.
- Modify CNewMenu::LoadItem in shell32.
* [OPENGL32] Use NDK definitions for list functions
* [OPENGL32] wglCreateLayerContext: Insert an entry into context list
Fixes a crash when wglDeleteContext is called on layer context.
Follow-up of #8641. Reduce freetype.c lines.
JIRA issue: CORE-19898
- Follow @HBelusca's review in #8641.
- Move some codes in freetype.c into utils.c.
Ensure we dereference the same parent window object after a user-mode callback. We cache spwndParent in a local before sending messages so a parent change during the callback no longer trips the LIFO reference check.
- Capture the parent window in a local in IntDefWindowProc (WM_APPCOMMAND) and IntSendParentNotify.
- Use the local for UserRefObjectCo, co_IntSendMessage, and UserDerefObjectCo to prevent object mismatches when the parent changes mid-callback.
CORE-17331
[FREETYPE] HACK: Verify the cmap format 4 is used in the function
"tt_cmap4_char_map_binary" in ttcmap.c before proceeding.
Otherwise issue debug message.
CORE-12549
- Update AFD to use the shared structure
- Fix AFD get context to match windows behavior
- implement SO_UPDATE_CONNECT_CONTEXT
CORE-17174
CORE-16335
The remove and assign commands work properly now.
Text rendering speed is justice! Font
search is heavy operation. Adding
cache to it is rational.
JIRA issue: CORE-19898
- Define FONT_LOOKUP_CACHE
structure.
- Add s_FontLookupCacheList
global variable to save cache.
- Use cache in FontLink_PrepareFontInfo
and TextIntRealizeFont.
Follow-up of #8633. Relative path parsing.
JIRA issue: CORE-20473
Modify CAddressEditBox::ParseNow.
Fixes a crash when booting with special pool enabled
Addendum to 0511e9d869fc8921dffbff2007e28d5cfdafd40c
Prepare to support CTF IMEs.
The IS_IME_HKL macro cannot
detect CTF IME.
JIRA issue: CORE-1926
- Use ImmIsIME instead of
IS_IME_HKL to check whether
the keyboard is IME.
Testing confirmed that the data is copied into the list view and can
be discarded by the caller. Docs showed that the list view writes into
the caller position, and doesn't change the pointer value.
Interestingly, when a callback is used, the listview allocates to
place the data, probably to not "split" ownership or double allocate.
On many Intel Macs and likely other EFI 1.x devices, allocating
the disk buffer with AllocatePool fails with `EFI_OUT_OF_RESOURCES`.
This causes FreeLoader hardware detection failure on Macs.
Workaround this issue by allocating with `MmAllocateMemoryWithType`
if `AllocatePool` via Boot Services fails.
CORE-11954
Implement the Alt+Numpad method for inserting characters with their
OEM (Alt+xxx) or their current ANSI codepage (Alt+0xxx) codes.
CORE-5680
For reference, see:
- https://en.wikipedia.org/wiki/Alt_code
- https://devblogs.microsoft.com/oldnewthing/20240702-00/?p=109951
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
The test used the obsolete CRT. The test doesn't provide much value anyway, because we test all the used code already through msvcrt_apitest, ntdll_apitest, etc. The only real benefit was testing and working outside of reactos.
I kept the build file around, which could be revived with msvcrt_static or libcntpr, but that needs some work.
Improve usability of Fonts folder.
JIRA issue: CORE-17311
- Modify PIDL design to contain
name and filename.
- Implement CFontExt::
ParseDisplayName to parsing
name as PIDL.
- Modify CDefaultContextMenu::
GetCommandString and
CDefaultContextMenu::
DoCopyOrCut for DFM_GETVERBA,
DFM_GETVERBW, DFM_CMD_COPY,
and DFM_CMD_MOVE.
- Add IDS_CONFIRM_DELETE_FONT,
IDS_CANTDELETEFONT, and
IDS_PROPERTIES resource strings.
- Add SHMultiFileProperties
prototype to <shlobj.h>.
Follow-up of #8632. Improve usability of ZIP Folder.
JIRA issue: CORE-20464
- Add IDS_CONFIRMDELETE_TEXT and
IDS_CANTDELETEFILE resource strings.
- When deleting files in Zip Folder, create a
temporary file.
- CZipFolder::CopyZipEntry adds files to the
temporary file without adding files to delete.
- Replacing the target ZIP file with the temporary
file implements deleting files in Zip Folder.
- Add SFGAO_CANDELETE attribute.
- Add DFM_CMD_DELETE action.
- Modify CDefaultContextMenu in shell32 to invoke DFM_CMD_DELETE etc.
- Modify CNewMenu::LoadItem in shell32.
Ensure we dereference the same parent window object after a user-mode callback. We cache spwndParent in a local before sending messages so a parent change during the callback no longer trips the LIFO reference check.
- Capture the parent window in a local in IntDefWindowProc (WM_APPCOMMAND) and IntSendParentNotify.
- Use the local for UserRefObjectCo, co_IntSendMessage, and UserDerefObjectCo to prevent object mismatches when the parent changes mid-callback.
CORE-17331