evbogue.com
secure-scuttlebot classic
Re-add getAddress() for non-MuxRPC method calls
Problem: Removing all `getAddress()` usage was too aggressive -- it's
still a method that Secret-Stack exposes, and so we should still test
for it, but we should **only test for it over in-process method calls**.
When using MuxRPC, we should always use `address()`.
Solution: Use `getAddress()` when the method isn't being called via
MuxRPC.
+4
-4
+4
-4
test/caps.js
+4
-4
test/caps.js
···
38
38
temp: 'server-bob',
39
39
port: 45452, timeout: 1400,
40
40
keys: ssbKeys.generate(),
41
-
seeds: [dbA.address()],
41
+
seeds: [dbA.getAddress()],
42
42
level: 'info'
43
43
})
44
44
···
70
70
})
71
71
72
72
tape('cannot connect if different shs caps, custom -> default', function (t) {
73
-
dbA.connect(dbB.address(), function (err) {
73
+
dbA.connect(dbB.getAddress(), function (err) {
74
74
t.ok(err)
75
75
console.log(err.stack)
76
76
···
79
79
})
80
80
81
81
tape('cannot connect if different shs caps, default -> custom', function (t) {
82
-
dbB.connect(dbA.address(), function (err) {
82
+
dbB.connect(dbA.getAddress(), function (err) {
83
83
t.ok(err)
84
84
85
85
console.log(err.stack)
···
88
88
})
89
89
90
90
tape('cannot connect if different shs caps, default -> custom', function (t) {
91
-
dbC.connect(dbA.address(), function (err) {
91
+
dbC.connect(dbA.getAddress(), function (err) {
92
92
if(err) throw err
93
93
t.end()
94
94
})