The (aspirational) foundation of CS at WCU!

rs-lti: init #57

Closed

bwc9876.dev 4w ago

targeting main from ben/init-basic-apps

Closed opened by and assigned to

bwc9876.dev 4w ago targeting main from ben/init-basic-apps

Commits 9

rs-lti: init

+803 -70

rs-openidconnect: init

+22541 -505

rs-runner: init

+1062 -25

contributing: add with some basic info

+34

justfile: add dev server recipe

+4

rs-auth: add configuration

+29 -10

rs-top: add config loading

+110 -13

rs-auth: init

+2368 -71

rs-TEMP: rm

-46

Comments

bwc9876.dev 1mo ago

Forgot to run formatter, oops

bwc9876.dev 1mo ago

config.dev.toml:7

Document this change in the auth crate config!!

bwc9876.dev 1mo ago

pkgs/rs-lti/askama.toml:2

Should we symlink the askama config instead?

bwc9876.dev 1mo ago

pkgs/rs-lti/dyn_reg.rs:135

Will absolutely want a better way to generate this in the future

bwc9876.dev 1mo ago

pkgs/rs-lti/dyn_reg.rs:170

Unused, remove

bwc9876.dev 1mo ago

pkgs/rs-lti/routes.rs:36

At some point I'd like to expose errors in UI nicer than just a string response.

huy55465.tngl.sh 4w ago

pkgs/rs-lti/claims.rs:44Since our DocumentTarget in pkgs/rs-lti/claims.rs:16 are also serde, can we use Vec<DocumentTarget> here?

huy55465.tngl.sh 4w ago

pkgs/rs-lti/claims.rs:58is this optional as well?

v0 4w ago

huy55465.tngl.sh 4w ago

pkgs/rs-lti/dyn_reg.rs:312whatever happened here hmm

huy55465.tngl.sh 4w ago

pkgs/rs-lti/routes.rs:39 wait what is this syntax?

huy55465.tngl.sh 4w ago

But still, LGTM

demsem.dev 3w ago

pkgs/rs-lti/routes.rs:39 I believe it is binding x to one of those three err values. Seems like a succinct way to do something specific to those three values

LGTM too