rs-openidconnect: init #56

Closed

bwc9876.dev 4w ago

targeting main from ben/init-basic-apps

Closed opened by and assigned to

bwc9876.dev 4w ago targeting main from ben/init-basic-apps

Commits 8

rs-openidconnect: init

+22541 -505

rs-runner: init

+1062 -25

contributing: add with some basic info

+34

justfile: add dev server recipe

rs-auth: add configuration

+29 -10

rs-top: add config loading

+110 -13

rs-auth: init

+2368 -71

rs-TEMP: rm

-46

Comments

bwc9876.dev 1mo ago

We will probably vendor this smarter later.

huy55465.tngl.sh 4w ago

Cargo.lock:3hmm i wonder what happened

huy55465.tngl.sh 4w ago

Also, can you put a note of what part(s) of this crate we modified?

bwc9876.dev 4w ago

I document the modifications in the README of the crate towards the top in the section titled "LTI Changes"

v0 4w ago

huy55465.tngl.sh 4w ago

LGTM, but partly 'cuz I'm not reading all 20k+ lines...

huy55465.tngl.sh 4w ago

The crate complains about some deprecated use of sha2::digest::generic_array::GenericArray::<T, N>::as_slice in pkgs/rs-openidconnect/src/core/jwk/mod.rs at 426:40, 433:40 and 440:40

demsem.dev 3w ago

LGTM

pkgs/tests/manual-blocker.nix:13 just curious why we dropped --ignore-case? Were we getting false-positives?

huy55465.tngl.sh 3w ago

I think because somewhere in the openidconnect crate they used XXX as well.

Versions