package config import ( "os" "path/filepath" "strings" "testing" "time" ) // writeFeedsDir creates a temp dir holding feeds.toml with the given contents // and a valid pattern file at patterns/p.json; it returns the feeds.toml path. func writeFeedsDir(t *testing.T, feedsTOML string) string { t.Helper() dir := t.TempDir() if err := os.MkdirAll(filepath.Join(dir, "patterns"), 0o755); err != nil { t.Fatal(err) } pattern := `{"commit": {"record": {"text": [{"shellstyle": "*go*"}]}}}` if err := os.WriteFile(filepath.Join(dir, "patterns", "p.json"), []byte(pattern), 0o644); err != nil { t.Fatal(err) } path := filepath.Join(dir, "feeds.toml") if err := os.WriteFile(path, []byte(feedsTOML), 0o644); err != nil { t.Fatal(err) } return path } func TestLoadFeedsMergesDefaultsAndOverrides(t *testing.T) { path := writeFeedsDir(t, ` [default] page_size = 25 max_age = "24h" track_likes = true [feeds.plain] pattern = "patterns/p.json" [feeds.hot] pattern = "patterns/p.json" algorithm = "hot" gravity = 0.5 max_age = "72h" [feeds.nolikes] pattern = "patterns/p.json" track_likes = false `) feeds, err := LoadFeeds(path) if err != nil { t.Fatalf("LoadFeeds: %v", err) } if len(feeds) != 3 { t.Fatalf("got %d feeds, want 3", len(feeds)) } // Sorted by name: hot, nolikes, plain. hot, nolikes, plain := feeds[0], feeds[1], feeds[2] if plain.Name != "plain" || plain.PageSize != 25 || plain.MaxAge != 24*time.Hour || plain.Algorithm != AlgorithmChronological || plain.Gravity != 0.1 || !plain.TrackLikes { t.Errorf("plain = %+v, want [default] values plus built-in defaults", plain) } if len(plain.Rules) != 1 || len(plain.Rules[0].Patterns) != 1 || plain.Rules[0].Target != "" { t.Fatalf("Rules = %+v, want pattern shorthand as one single-pattern rule targeting the matched post", plain.Rules) } pattern := plain.Rules[0].Patterns[0] if pattern.Path != filepath.Join(filepath.Dir(path), "patterns", "p.json") { t.Errorf("Path = %q, want path relative to feeds.toml", pattern.Path) } if !strings.Contains(pattern.JSON, "shellstyle") { t.Errorf("JSON = %q, want pattern file contents", pattern.JSON) } if hot.Algorithm != AlgorithmHot || hot.Gravity != 0.5 || hot.MaxAge != 72*time.Hour || hot.PageSize != 25 { t.Errorf("hot = %+v, want overrides applied over [default]", hot) } if nolikes.TrackLikes { t.Errorf("nolikes.TrackLikes = true, want false override of [default] true") } } func TestLoadFeedsValidationErrors(t *testing.T) { tests := []struct { name string toml string wantErr string }{ {"no feeds", `[default]`, "defines no feeds"}, {"unknown key", "[feeds.a]\npattern = \"patterns/p.json\"\npagesize = 3", "unknown keys"}, {"missing pattern", "[feeds.a]\n", "pattern or rules is required"}, {"pattern and rules", "[feeds.a]\npattern = \"patterns/p.json\"\n[[feeds.a.rules]]\npatterns = [\"patterns/p.json\"]", "not both"}, {"rule without patterns", "[[feeds.a.rules]]\ntarget = \"commit.record.reply.parent\"", "rules[0]: patterns is required"}, {"rule pattern file missing", "[[feeds.a.rules]]\npatterns = [\"patterns/p.json\", \"nope.json\"]", "rules[0]: reading pattern"}, {"bad target", "[[feeds.a.rules]]\npatterns = [\"patterns/p.json\"]\ntarget = \"commit..parent\"", "not a valid dot path"}, {"unknown rule key", "[[feeds.a.rules]]\npatterns = [\"patterns/p.json\"]\ntargte = \"x\"", "unknown keys"}, {"pattern file missing", "[feeds.a]\npattern = \"nope.json\"", "reading pattern"}, {"bad page size", "[feeds.a]\npattern = \"patterns/p.json\"\npage_size = 101", "page_size"}, {"bad max age", "[feeds.a]\npattern = \"patterns/p.json\"\nmax_age = \"soon\"", "max_age"}, {"bad algorithm", "[feeds.a]\npattern = \"patterns/p.json\"\nalgorithm = \"random\"", "algorithm must be"}, {"hot without likes", "[feeds.a]\npattern = \"patterns/p.json\"\nalgorithm = \"hot\"", "requires track_likes"}, {"hot without gravity", "[feeds.a]\npattern = \"patterns/p.json\"\nalgorithm = \"hot\"\ntrack_likes = true\ngravity = 0.0", "requires gravity"}, {"bad name", "[feeds.\"a/b\"]\npattern = \"patterns/p.json\"", "record key"}, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { _, err := LoadFeeds(writeFeedsDir(t, tt.toml)) if err == nil || !strings.Contains(err.Error(), tt.wantErr) { t.Fatalf("err = %v, want containing %q", err, tt.wantErr) } }) } } func TestLoadFeedsResolvesRules(t *testing.T) { path := writeFeedsDir(t, ` [feeds.a] max_age = "1h" [[feeds.a.rules]] patterns = ["patterns/p.json"] target = "commit.record.reply.parent" [[feeds.a.rules]] patterns = ["patterns/p.json", "patterns/p.json"] `) feeds, err := LoadFeeds(path) if err != nil { t.Fatalf("LoadFeeds: %v", err) } rules := feeds[0].Rules if len(rules) != 2 { t.Fatalf("got %d rules, want 2", len(rules)) } if rules[0].Target != "commit.record.reply.parent" || len(rules[0].Patterns) != 1 { t.Errorf("rules[0] = %+v, want one pattern with the reply parent target", rules[0]) } if rules[1].Target != "" || len(rules[1].Patterns) != 2 { t.Errorf("rules[1] = %+v, want two patterns targeting the matched post", rules[1]) } for _, rule := range rules { for _, pattern := range rule.Patterns { if !strings.Contains(pattern.JSON, "shellstyle") { t.Errorf("JSON = %q, want pattern file contents", pattern.JSON) } } } } func TestLoadFeedsRejectsInvalidPatternJSON(t *testing.T) { path := writeFeedsDir(t, "[feeds.a]\npattern = \"bad.json\"") if err := os.WriteFile(filepath.Join(filepath.Dir(path), "bad.json"), []byte("{nope"), 0o644); err != nil { t.Fatal(err) } _, err := LoadFeeds(path) if err == nil || !strings.Contains(err.Error(), "not valid JSON") { t.Fatalf("err = %v, want invalid JSON error", err) } }