Something went wrong. Try again.
A lexicon-driven AppView for ATProto. forked from gamesgamesgamesgames.games/happyview
Something went wrong. Try again.
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802mod common;
use happyview::db::now_rfc3339;use happyview::spaces::db as spaces_db;use happyview::spaces::notifications;use happyview::spaces::oplog;use happyview::spaces::types::*;use serial_test::serial;use uuid::Uuid;
use common::db as test_db;
// ---------------------------------------------------------------------------// Helpers// ---------------------------------------------------------------------------
fn new_id() -> String { Uuid::new_v4().to_string()}
fn make_space(id: &str, did: &str, type_nsid: &str, skey: &str) -> Space { let now = now_rfc3339(); Space { id: id.to_string(), did: did.to_string(), authority_did: did.to_string(), creator_did: did.to_string(), type_nsid: type_nsid.to_string(), skey: skey.to_string(), display_name: Some("Test Space".to_string()), description: None, mint_policy: MintPolicy::MemberList, app_access: AppAccess::Open, managing_app_did: None, config: SpaceConfig::default(), revision: None, created_at: now.clone(), updated_at: now, }}
// ---------------------------------------------------------------------------// Space CRUD// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn create_and_get_space_roundtrip() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let id = new_id(); let did = "did:plc:spaces-test-owner"; let space = make_space(&id, did, "com.example.test", "myspace");
spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let fetched = spaces_db::get_space(&pool, backend, &id) .await .expect("get_space failed") .expect("space not found after creation");
assert_eq!(fetched.id, id); assert_eq!(fetched.did, did); assert_eq!(fetched.type_nsid, "com.example.test"); assert_eq!(fetched.skey, "myspace"); assert_eq!(fetched.display_name, Some("Test Space".to_string())); assert_eq!(fetched.mint_policy, MintPolicy::MemberList); assert!(matches!(fetched.app_access, AppAccess::Open));}
#[tokio::test]#[serial]async fn get_space_by_address_roundtrip() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let id = new_id(); let did = "did:plc:addr-test"; let space = make_space(&id, did, "com.example.addr", "addr-skey"); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let fetched = spaces_db::get_space_by_address(&pool, backend, did, "com.example.addr", "addr-skey") .await .expect("get_space_by_address failed") .expect("space not found by address");
assert_eq!(fetched.id, id);}
#[tokio::test]#[serial]async fn list_spaces_by_owner() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let owner = "did:plc:list-owner"; let other = "did:plc:other-owner";
for i in 0..3 { let space = make_space(&new_id(), owner, "com.example.list", &format!("space-{i}")); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed"); } let space = make_space(&new_id(), other, "com.example.list", "other-space"); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let owned = spaces_db::list_spaces_by_owner(&pool, backend, owner) .await .expect("list_spaces_by_owner failed"); assert_eq!(owned.len(), 3);
let other_owned = spaces_db::list_spaces_by_owner(&pool, backend, other) .await .expect("list_spaces_by_owner failed"); assert_eq!(other_owned.len(), 1);}
#[tokio::test]#[serial]async fn delete_space_removes_it() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let id = new_id(); let space = make_space(&id, "did:plc:del-owner", "com.example.del", "del-skey"); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let deleted = spaces_db::delete_space(&pool, backend, &id) .await .expect("delete_space failed"); assert!(deleted);
let after = spaces_db::get_space(&pool, backend, &id) .await .expect("get_space failed"); assert!(after.is_none());}
// ---------------------------------------------------------------------------// Repo state// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn get_or_create_repo_state_creates_default() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space( &space_id, "did:plc:repo-owner", "com.example.repo", "repo-skey", ); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let author_did = "did:plc:repo-author"; let state = spaces_db::get_or_create_repo_state(&pool, backend, &space_id, author_did) .await .expect("get_or_create_repo_state failed");
assert_eq!(state.space_id, space_id); assert_eq!(state.author_did, author_did); assert_eq!(state.lthash_state, vec![0u8; 2048]); assert!(state.rev.is_none()); assert!(state.hash.is_none());}
#[tokio::test]#[serial]async fn get_or_create_repo_state_is_idempotent() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space( &space_id, "did:plc:idem-owner", "com.example.idem", "idem-skey", ); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let author_did = "did:plc:idem-author"; let first = spaces_db::get_or_create_repo_state(&pool, backend, &space_id, author_did) .await .expect("first call failed"); let second = spaces_db::get_or_create_repo_state(&pool, backend, &space_id, author_did) .await .expect("second call failed");
assert_eq!(first.id, second.id);}
#[tokio::test]#[serial]async fn update_repo_state_persists_fields() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space( &space_id, "did:plc:update-owner", "com.example.upd", "upd-skey", ); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let author_did = "did:plc:update-author"; let mut state = spaces_db::get_or_create_repo_state(&pool, backend, &space_id, author_did) .await .expect("get_or_create failed");
state.rev = Some("rev-001".to_string()); state.hash = Some(vec![0xde, 0xad, 0xbe, 0xef]);
spaces_db::update_repo_state(&pool, backend, &state) .await .expect("update_repo_state failed");
let reloaded = spaces_db::get_or_create_repo_state(&pool, backend, &space_id, author_did) .await .expect("reload failed");
assert_eq!(reloaded.rev, Some("rev-001".to_string())); assert_eq!(reloaded.hash, Some(vec![0xde, 0xad, 0xbe, 0xef]));}
// ---------------------------------------------------------------------------// Oplog// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn oplog_append_and_list() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space( &space_id, "did:plc:oplog-owner", "com.example.oplog", "oplog-skey", ); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let author_did = "did:plc:oplog-author";
for (i, action) in [ OplogAction::Create, OplogAction::Update, OplogAction::Delete, ] .iter() .enumerate() { let entry = OplogEntry { id: new_id(), space_id: space_id.clone(), author_did: author_did.to_string(), rev: format!("rev-{:04}", i + 1), idx: 0, action: *action, collection: "com.example.item".to_string(), rkey: format!("item-{i}"), cid: Some(format!("bafy{i}")), prev: if i > 0 { Some(format!("rev-{:04}", i)) } else { None }, value: None, created_at: now_rfc3339(), }; oplog::append_op(&pool, backend, &entry) .await .expect("append_op failed"); }
let all_ops = oplog::list_ops(&pool, backend, &space_id, author_did, None, 10) .await .expect("list_ops failed"); assert_eq!(all_ops.len(), 3); assert!(matches!(all_ops[0].action, OplogAction::Create)); assert!(matches!(all_ops[1].action, OplogAction::Update)); assert!(matches!(all_ops[2].action, OplogAction::Delete));}
#[tokio::test]#[serial]async fn oplog_list_with_since_rev_cursor() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space( &space_id, "did:plc:cursor-owner", "com.example.cursor", "cursor-skey", ); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let author_did = "did:plc:cursor-author";
for i in 0..5 { let entry = OplogEntry { id: new_id(), space_id: space_id.clone(), author_did: author_did.to_string(), rev: format!("rev-{:04}", i + 1), idx: 0, action: OplogAction::Create, collection: "com.example.item".to_string(), rkey: format!("item-{i}"), cid: Some(format!("bafy{i}")), prev: None, value: None, created_at: now_rfc3339(), }; oplog::append_op(&pool, backend, &entry) .await .expect("append_op failed"); }
let after_rev2 = oplog::list_ops(&pool, backend, &space_id, author_did, Some("rev-0002"), 10) .await .expect("list_ops with cursor failed");
assert_eq!(after_rev2.len(), 3); assert_eq!(after_rev2[0].rev, "rev-0003");}
// ---------------------------------------------------------------------------// Notification registrations// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn register_and_list_notify_registrations() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space( &space_id, "did:plc:notify-owner", "com.example.notify", "notify-skey", ); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let service_did = "did:plc:notify-service"; let endpoint = "https://service.example.com/notify"; let registered_by = "did:plc:notify-owner";
let reg_id = notifications::register( &pool, backend, &space_id, service_did, endpoint, registered_by, ) .await .expect("register failed"); assert!(!reg_id.is_empty());
let all_regs = spaces_db::list_notify_registrations(&pool, backend, &space_id, None) .await .expect("list_notify_registrations failed"); assert_eq!(all_regs.len(), 1); assert_eq!(all_regs[0].id, reg_id); assert_eq!(all_regs[0].endpoint, endpoint); assert_eq!(all_regs[0].author_did, Some(service_did.to_string()));
let by_did = spaces_db::list_notify_registrations(&pool, backend, &space_id, Some(service_did)) .await .expect("list_notify_registrations by did failed"); assert_eq!(by_did.len(), 1);}
#[tokio::test]#[serial]async fn delete_notify_registration_removes_it() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space( &space_id, "did:plc:del-notify-owner", "com.example.delnotify", "dn-skey", ); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let reg_id = notifications::register( &pool, backend, &space_id, "did:plc:svc", "https://svc.example.com/n", "did:plc:del-notify-owner", ) .await .expect("register failed");
let deleted = spaces_db::delete_notify_registration(&pool, backend, ®_id) .await .expect("delete_notify_registration failed"); assert!(deleted);
let remaining = spaces_db::list_notify_registrations(&pool, backend, &space_id, None) .await .expect("list after delete failed"); assert!(remaining.is_empty());}
// ---------------------------------------------------------------------------// Space members// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn add_and_get_member() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space( &space_id, "did:plc:member-owner", "com.example.member", "member-skey", ); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let member_did = "did:plc:new-member"; let member = SpaceMember { id: new_id(), space_id: space_id.clone(), did: member_did.to_string(), access: SpaceAccess::Read, is_delegation: false, granted_by: Some("did:plc:member-owner".to_string()), created_at: now_rfc3339(), }; spaces_db::add_member(&pool, backend, &member) .await .expect("add_member failed");
let fetched = spaces_db::get_member(&pool, backend, &space_id, member_did) .await .expect("get_member failed") .expect("member not found");
assert_eq!(fetched.did, member_did); assert_eq!(fetched.access, SpaceAccess::Read); assert!(!fetched.is_delegation);}
#[tokio::test]#[serial]async fn resolve_members_preserves_read_self() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space( &space_id, "did:plc:rs-owner", "com.example.readself", "rs-skey", ); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let member_did = "did:plc:rs-member"; spaces_db::add_member( &pool, backend, &SpaceMember { id: new_id(), space_id: space_id.clone(), did: member_did.to_string(), access: SpaceAccess::ReadSelf, is_delegation: false, granted_by: Some("did:plc:rs-owner".to_string()), created_at: now_rfc3339(), }, ) .await .expect("add_member failed");
// Resolution must not promote read_self to full read. let access = happyview::spaces::members::is_member(&pool, backend, &space_id, member_did) .await .expect("is_member failed"); assert_eq!(access, Some(SpaceAccess::ReadSelf));}
#[tokio::test]#[serial]async fn space_credential_revocation_round_trip() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space(&space_id, "did:plc:cred-owner", "com.example.cred", "cred"); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let member = "did:plc:cred-member"; let token_hash = "abc123hash"; let sql = happyview::db::adapt_sql( "INSERT INTO happyview_space_credentials (id, space_id, issued_to, token_hash, expires_at, created_at) VALUES (?, ?, ?, ?, ?, ?)", backend, ); happyview::db::query(&sql) .bind(new_id()) .bind(&space_id) .bind(member) .bind(token_hash) .bind(now_rfc3339()) .bind(now_rfc3339()) .execute(&pool) .await .expect("insert credential row");
assert!( !spaces_db::is_space_credential_revoked(&pool, backend, token_hash) .await .unwrap() );
let revoked = spaces_db::revoke_space_credentials_for_member(&pool, backend, &space_id, member) .await .unwrap(); assert_eq!(revoked, 1);
assert!( spaces_db::is_space_credential_revoked(&pool, backend, token_hash) .await .unwrap() );}
#[tokio::test]#[serial]async fn remove_member() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space(&space_id, "did:plc:rm-owner", "com.example.rm", "rm-skey"); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let member_did = "did:plc:rm-member"; let member = SpaceMember { id: new_id(), space_id: space_id.clone(), did: member_did.to_string(), access: SpaceAccess::Write, is_delegation: false, granted_by: None, created_at: now_rfc3339(), }; spaces_db::add_member(&pool, backend, &member) .await .expect("add_member failed");
let removed = spaces_db::remove_member(&pool, backend, &space_id, member_did) .await .expect("remove_member failed"); assert!(removed);
let after = spaces_db::get_member(&pool, backend, &space_id, member_did) .await .expect("get_member after remove failed"); assert!(after.is_none());}
// ---------------------------------------------------------------------------// Space records// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn upsert_and_get_space_record() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space( &space_id, "did:plc:rec-owner", "com.example.rec", "rec-skey", ); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let author_did = "did:plc:rec-author"; let uri = format!("at://{author_did}/com.example.item/rec001"); let record = SpaceRecord { uri: uri.clone(), space_id: space_id.clone(), author_did: author_did.to_string(), collection: "com.example.item".to_string(), rkey: "rec001".to_string(), record: serde_json::json!({"title": "hello"}), cid: "bafycid001".to_string(), indexed_at: now_rfc3339(), };
spaces_db::upsert_space_record(&pool, backend, &record) .await .expect("upsert_space_record failed");
let fetched = spaces_db::get_space_record(&pool, backend, &uri) .await .expect("get_space_record failed") .expect("record not found");
assert_eq!(fetched.uri, uri); assert_eq!(fetched.record["title"], "hello"); assert_eq!(fetched.cid, "bafycid001");}
#[tokio::test]#[serial]async fn upsert_space_record_overwrites_existing() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let space = make_space( &space_id, "did:plc:upsert-owner", "com.example.upsert", "upsert-skey", ); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let uri = "at://did:plc:upsert-author/com.example.item/upd001"; let first = SpaceRecord { uri: uri.to_string(), space_id: space_id.clone(), author_did: "did:plc:upsert-author".to_string(), collection: "com.example.item".to_string(), rkey: "upd001".to_string(), record: serde_json::json!({"v": 1}), cid: "cid-v1".to_string(), indexed_at: now_rfc3339(), }; spaces_db::upsert_space_record(&pool, backend, &first) .await .expect("first upsert failed");
let second = SpaceRecord { record: serde_json::json!({"v": 2}), cid: "cid-v2".to_string(), ..first }; spaces_db::upsert_space_record(&pool, backend, &second) .await .expect("second upsert failed");
let fetched = spaces_db::get_space_record(&pool, backend, uri) .await .expect("get_space_record failed") .expect("record not found"); assert_eq!(fetched.record["v"], 2); assert_eq!(fetched.cid, "cid-v2");}
// ---------------------------------------------------------------------------// find_blob_author_did — LIKE wildcard safety (L8)// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn find_blob_author_did_treats_cid_wildcards_literally() { common::require_db!(); let pool = test_db::test_pool().await; let backend = test_db::test_backend(); test_db::truncate_all(&pool).await;
let space_id = new_id(); let did = "did:plc:blob-space-owner"; let space = make_space(&space_id, did, "com.example.test", "blobspace"); spaces_db::create_space(&pool, backend, &space) .await .expect("create_space failed");
let author = "did:plc:blob-author"; let blob_cid = "bafyrealcid"; let record = SpaceRecord { uri: format!("at://{did}/space/com.example.test/blobspace/{author}/com.example.post/rk1"), space_id: space_id.clone(), author_did: author.to_string(), collection: "com.example.post".to_string(), rkey: "rk1".to_string(), record: serde_json::json!({ "image": { "$link": blob_cid } }), cid: "bafyrecordcid".to_string(), indexed_at: now_rfc3339(), }; spaces_db::insert_space_record(&pool, backend, &record) .await .expect("insert_space_record failed");
// A genuine CID still resolves to the author (escaping must not break lookups). let found = spaces_db::find_blob_author_did(&pool, backend, &space_id, blob_cid) .await .unwrap(); assert_eq!(found.as_deref(), Some(author));
// `%` must be matched literally, not as a wildcard that leaks any blob ref. let wildcard = spaces_db::find_blob_author_did(&pool, backend, &space_id, "%") .await .unwrap(); assert_eq!(wildcard, None, "'%' leaked a record via a LIKE wildcard");
// `_` must not match the single differing character of a real CID. let underscore = spaces_db::find_blob_author_did(&pool, backend, &space_id, "bafyreal_id") .await .unwrap(); assert_eq!(underscore, None, "'_' leaked a record via a LIKE wildcard");}