Something went wrong. Try again.
A lexicon-driven AppView for ATProto. forked from gamesgamesgamesgames.games/happyview
Something went wrong. Try again.
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440use crate::AppState;use crate::auth::COOKIE_NAME;use crate::db::{adapt_sql, now_rfc3339};use crate::error::AppError;use atrium_oauth::{AuthorizeOptions, KnownScope, Scope};use axum::{ Json, Router, extract::{Query, State}, response::Redirect, routing::{get, post},};use axum_extra::extract::cookie::{Cookie, Key, SignedCookieJar};use serde::Deserialize;
/// Legacy cookie name from the old cookie-based redirect approach./// Detected and removed in the callback to clean up stale cookies.const LEGACY_REDIRECT_COOKIE: &str = "happyview_redirect";
fn is_https(public_url: &str) -> bool { public_url.starts_with("https://")}
#[derive(Deserialize)]pub struct LoginQuery { handle: String, redirect_uri: Option<String>, scope: Option<String>, client_id: Option<String>,}
/// Parse a whitespace-separated OAuth scope string into typed `Scope` values./// Known ATProto scope names are mapped to `Scope::Known`; anything else/// (e.g. `include:*` permission set references) becomes `Scope::Unknown`.pub fn parse_scope_string(scope_str: &str) -> Vec<Scope> { scope_str .split_whitespace() .map(|s| match s { "atproto" => Scope::Known(KnownScope::Atproto), "transition:generic" => Scope::Known(KnownScope::TransitionGeneric), "transition:chat.bsky" => Scope::Known(KnownScope::TransitionChatBsky), other => Scope::Unknown(other.to_string()), }) .collect()}
#[derive(Deserialize)]pub struct CallbackQuery { code: String, state: Option<String>, iss: Option<String>,}
pub fn routes() -> Router<AppState> { Router::new() .route("/login", get(login)) .route("/callback", get(callback)) .route("/logout", post(logout)) .route("/me", get(me))}
async fn login( State(state): State<AppState>, jar: SignedCookieJar<Key>, domain: Option<axum::extract::Extension<std::sync::Arc<crate::domain::Domain>>>, Query(query): Query<LoginQuery>,) -> Result<(SignedCookieJar<Key>, Json<serde_json::Value>), AppError> { // Refuse to start a login flow we cannot finish securely: the session cookie // set by the callback is signed with the SESSION_SECRET-derived key. if !state.config.session_secret_secure() { return Err(AppError::ServerMisconfigured( crate::auth::COOKIE_AUTH_DISABLED_MSG.into(), )); }
tracing::debug!(handle = %query.handle, redirect_uri = ?query.redirect_uri, scope = ?query.scope, "login request");
// Use scopes from the query param if provided, otherwise fall back to the // settings DB. The client metadata advertises all possible scopes, but each // login request can ask for a subset. let scopes = if let Some(ref scope_str) = query.scope { let parsed = parse_scope_string(scope_str); if parsed.is_empty() { vec![Scope::Known(KnownScope::Atproto)] } else { parsed } } else { vec![Scope::Known(KnownScope::Atproto)] };
tracing::debug!(scopes = ?scopes, client_id = ?query.client_id, "resolved oauth scopes");
// For dashboard logins (no explicit client_id), use the domain's OAuth client let domain_url = domain.map(|d| d.0.url.clone()); let effective_client_id = if query.client_id.is_some() { query.client_id.clone() } else { domain_url .as_ref() .map(|du| format!("{}/oauth-client-metadata.json", du.trim_end_matches('/'))) };
// Select the appropriate OAuth client based on client_id let oauth_client = state.oauth.get_or_default(effective_client_id.as_deref());
// Hold the authorize lock so that authorize() + take_last_state_key() are atomic. // This prevents concurrent logins from swapping each other's state keys. let _authorize_guard = state.oauth_state_store.authorize_lock.lock().await;
let options = AuthorizeOptions { scopes, ..Default::default() };
let url = oauth_client .authorize(&query.handle, options) .await .map_err(|e| AppError::Internal(format!("OAuth authorize failed: {e}")))?;
// Capture the state key immediately after authorize(). We can't parse it from the URL // because atrium uses PAR (Pushed Authorization Requests), so the state is embedded // in the pushed request, not visible in the URL. let oauth_state = state.oauth_state_store.take_last_state_key();
drop(_authorize_guard);
tracing::debug!(authorize_url = %url, "authorize URL generated");
// Store the redirect URI in the database, keyed by the OAuth state parameter. // This avoids third-party cookie issues when Pentaract (cross-origin) calls this endpoint. // Store redirect URI and client_id for the callback to use if query.redirect_uri.is_some() || effective_client_id.is_some() { let redirect_uri = query.redirect_uri.as_deref().unwrap_or(""); tracing::debug!(oauth_state = ?oauth_state, redirect_uri = %redirect_uri, client_id = ?effective_client_id, "storing redirect for state");
if let Some(oauth_state) = oauth_state { let now = now_rfc3339(); let expires_at = (chrono::Utc::now() + chrono::Duration::minutes(10)).to_rfc3339(); let sql = adapt_sql( "INSERT INTO happyview_auth_login_redirects (state, redirect_uri, client_id, created_at, expires_at) VALUES (?, ?, ?, ?, ?)", state.db_backend, ); let _ = crate::db::query(&sql) .bind(&oauth_state) .bind(redirect_uri) .bind(effective_client_id.as_deref()) .bind(&now) .bind(&expires_at) .execute(&state.db) .await; } else { tracing::warn!("no state key captured from OAuth authorize — redirect will be lost"); } }
Ok((jar, Json(serde_json::json!({ "url": url }))))}
async fn callback( State(state): State<AppState>, jar: SignedCookieJar<Key>, Query(query): Query<CallbackQuery>,) -> Result<(SignedCookieJar<Key>, Redirect), AppError> { // The callback sets the session cookie; refuse when its signing key is not // secure (mirrors the guard in `login`). if !state.config.session_secret_secure() { return Err(AppError::ServerMisconfigured( crate::auth::COOKIE_AUTH_DISABLED_MSG.into(), )); }
tracing::debug!(state = ?query.state, "callback received");
// Look up the redirect URI and client_id from the database before the OAuth library consumes the state let (redirect_url, client_id) = if let Some(oauth_state) = &query.state { let sql = adapt_sql( "SELECT redirect_uri, client_id FROM happyview_auth_login_redirects WHERE state = ? AND expires_at > ?", state.db_backend, ); let now = now_rfc3339(); let row: Option<(String, Option<String>)> = crate::db::query_as(&sql) .bind(oauth_state) .bind(&now) .fetch_optional(&state.db) .await .unwrap_or(None);
// Clean up the row (one-time use) if row.is_some() { let delete_sql = adapt_sql( "DELETE FROM happyview_auth_login_redirects WHERE state = ?", state.db_backend, ); let _ = crate::db::query(&delete_sql) .bind(oauth_state) .execute(&state.db) .await; }
tracing::debug!(found_redirect = ?row, "redirect lookup result"); match row { Some((uri, cid)) => { let uri = if uri.is_empty() { None } else { Some(uri) }; (uri, cid) } None => (None, None), } } else { tracing::debug!("no state in callback query"); (None, None) };
// Use the same OAuth client that was used for authorize let oauth_client = state.oauth.get_or_default(client_id.as_deref());
let params = atrium_oauth::CallbackParams { code: query.code, state: query.state, iss: query.iss, };
let (session, _app_state) = oauth_client .callback(params) .await .map_err(|e| AppError::Internal(format!("OAuth callback failed: {e}")))?;
use atrium_api::agent::SessionManager; let did = session .did() .await .ok_or_else(|| AppError::Internal("no DID in OAuth session".into()))?;
// Check if the user is authorized to access the dashboard. // Allow login when no users exist yet (first user will be bootstrapped as admin). // Also allow login for the configured attached account DID (setup attach-auth flow). // Otherwise, only allow users already in the users table. let user_count: (i64,) = crate::db::query_as("SELECT COUNT(*) FROM happyview_users") .fetch_one(&state.db) .await .map_err(|e| AppError::Internal(format!("user count query failed: {e}")))?;
if user_count.0 > 0 { let user_exists: Option<(i32,)> = crate::db::query_as(&adapt_sql( "SELECT 1 FROM happyview_users WHERE did = ?", state.db_backend, )) .bind(did.as_ref()) .fetch_optional(&state.db) .await .map_err(|e| AppError::Internal(format!("user lookup failed: {e}")))?;
if user_exists.is_none() { // Allow login if this DID is the configured attached account (setup flow) let is_attached_account: Option<(i32,)> = crate::db::query_as(&adapt_sql( "SELECT 1 FROM happyview_service_identity WHERE attached_account_did = ?", state.db_backend, )) .bind(did.as_ref()) .fetch_optional(&state.db) .await .unwrap_or(None);
if is_attached_account.is_none() { let login_url = state .config .base_path .as_ref() .map(|bp| format!("{}/login?error=not_authorized", bp)) .unwrap_or_else(|| "/login?error=not_authorized".into()); return Ok((jar, Redirect::to(&login_url))); } } }
// Look up the client_key for the API client so we can store it in the session cookie // for per-client rate limiting. let client_key = if let Some(ref cid) = client_id { let sql = adapt_sql( "SELECT client_key FROM happyview_api_clients WHERE client_id_url = ? AND is_active = 1", state.db_backend, ); let row: Option<(String,)> = crate::db::query_as(&sql) .bind(cid) .fetch_optional(&state.db) .await .unwrap_or(None); row.map(|(k,)| k) } else { None };
let default_redirect = state .config .base_path .as_ref() .map(|bp| format!("{}/dashboard/", bp)) .unwrap_or_else(|| "/dashboard/".into()); let redirect_url = redirect_url.unwrap_or(default_redirect); tracing::debug!(redirect_url = %redirect_url, "redirecting after callback");
// Set the session cookie // Must use SameSite=None for cross-origin requests (e.g., Pentaract calling HappyView) // Encode did and optional client_key separated by newline. let did_str = did.as_ref(); let cookie_value = if let Some(ref ck) = client_key { format!("{did_str}\n{ck}") } else { did_str.to_string() }; let secure = is_https(&state.config.public_url); let same_site = if secure { axum_extra::extract::cookie::SameSite::None } else { axum_extra::extract::cookie::SameSite::Lax }; let mut session_cookie = Cookie::new(COOKIE_NAME, cookie_value); session_cookie.set_path("/"); session_cookie.set_http_only(true); session_cookie.set_same_site(same_site); session_cookie.set_secure(secure);
// Remove the legacy redirect cookie if present (old cookie-based approach) let jar = if jar.get(LEGACY_REDIRECT_COOKIE).is_some() { let mut removal = Cookie::from(LEGACY_REDIRECT_COOKIE); removal.set_path("/"); removal.set_same_site(same_site); removal.set_secure(secure); jar.add(session_cookie).remove(removal) } else { jar.add(session_cookie) };
Ok((jar, Redirect::to(&redirect_url)))}
async fn logout( State(state): State<AppState>, jar: SignedCookieJar<Key>,) -> Result<SignedCookieJar<Key>, AppError> { if let Some(cookie) = jar.get(COOKIE_NAME) { let raw = cookie.value().to_string(); let did_str = raw.split('\n').next().unwrap_or(&raw).to_string(); if let Ok(did) = atrium_api::types::string::Did::new(did_str) { let _ = state.oauth.primary_client().revoke(&did).await; } }
let secure = is_https(&state.config.public_url); let same_site = if secure { axum_extra::extract::cookie::SameSite::None } else { axum_extra::extract::cookie::SameSite::Lax }; let mut removal = Cookie::from(COOKIE_NAME); removal.set_path("/"); removal.set_same_site(same_site); removal.set_secure(secure); let jar = jar.remove(removal); Ok(jar)}
#[derive(serde::Serialize)]struct MeResponse { did: String, is_admin: bool,}
async fn me( State(state): State<AppState>, jar: SignedCookieJar<Key>,) -> Result<Json<MeResponse>, AppError> { let cookie = jar .get(COOKIE_NAME) .ok_or(AppError::Auth("not authenticated".into()))?; let raw = cookie.value().to_string(); let did = raw.split('\n').next().unwrap_or(&raw).to_string();
let backend = state.db_backend; let user: Option<(i32,)> = crate::db::query_as(&adapt_sql( "SELECT 1 FROM happyview_users WHERE did = ?", backend, )) .bind(&did) .fetch_optional(&state.db) .await .map_err(|e| AppError::Internal(format!("user lookup failed: {e}")))?;
Ok(Json(MeResponse { did, is_admin: user.is_some(), }))}
#[cfg(test)]mod tests { use super::*;
#[test] fn parse_scope_string_maps_known_scopes() { let scopes = parse_scope_string("atproto transition:generic transition:chat.bsky"); assert_eq!(scopes.len(), 3); assert!(matches!(scopes[0], Scope::Known(KnownScope::Atproto))); assert!(matches!( scopes[1], Scope::Known(KnownScope::TransitionGeneric) )); assert!(matches!( scopes[2], Scope::Known(KnownScope::TransitionChatBsky) )); }
#[test] fn parse_scope_string_treats_unknown_as_unknown() { let scopes = parse_scope_string("atproto include:games.gamesgamesgamesgames.authBasic"); assert_eq!(scopes.len(), 2); assert!(matches!(scopes[0], Scope::Known(KnownScope::Atproto))); match &scopes[1] { Scope::Unknown(s) => { assert_eq!(s, "include:games.gamesgamesgamesgames.authBasic"); } _ => panic!("expected Scope::Unknown for include: reference"), } }
#[test] fn parse_scope_string_handles_extra_whitespace_and_empty_input() { let scopes = parse_scope_string(" atproto \n\t transition:generic "); assert_eq!(scopes.len(), 2); assert!(matches!(scopes[0], Scope::Known(KnownScope::Atproto))); assert!(matches!( scopes[1], Scope::Known(KnownScope::TransitionGeneric) ));
let empty = parse_scope_string(" \n \t "); assert!(empty.is_empty()); }}