Signed-off-by: estym evann.regnault@pm.me
Monorepo for Tangled
tangled.org
appview/pages : fix handle parsing false-positives #905
merged
opened by
expand 1 commit
hide 1 commit
appview/pages : fix handle parsing false-positives
Signed-off-by: estym <evann.regnault@pm.me>
expand 1 commit
hide 1 commit
appview/pages : fix handle parsing false-positives
Signed-off-by: estym <evann.regnault@pm.me>
expand 1 commit
hide 1 commit
appview/pages : fix handle parsing false-positives
Signed-off-by: estym <evann.regnault@pm.me>
expand 1 commit
hide 1 commit
appview/pages : fix handle parsing false-positives
Signed-off-by: estym <evann.regnault@pm.me>
Yours seems to work with my test readme, I'll close this PR
Wait no, i'm studid, there's two cases that aren't taken into account in your branch:
[
@regnault.dev](https://regnault.dev)
[@regnault.dev](https://regnault.dev)
those are both great cases! i wonder if we are barking up the wrong tree by implementing this as a unique node, instead of having a pass at the html generation stage.
i say we keep this, but ill also incorporate my PR with the updated regex + tests!
pull request successfully merged
i have created https://tangled.org/tangled.org/core/pulls/910 to handle false positives, along with some tests. are there any cases that this PR handles and the other one does not? note that the linkify extension (provided by
extensions.GFM) should run before the atlink extension for the test cases to work.i can't say i am too familiar with the atlink extension (or goldmark extensions for that matter), @boltless.me would be the right person to review this code.