commits
oh i also fixed how the "clear" action in the footer works. now its more consistent with sort, if you have a couple tracks selected it'll only delete those tracks, but if you have no selected tracks it'll delete everything.
(maybe i should also move the sort button to the queue context menu later? would be more consistent with the clear action)
in flake builds, the monolith tool is unable to inline images that are
not referenced directly in the html.
Signed-off-by: oppiliappan <me@oppi.li>
i think 32 is probably a good balance where it isnt noticeable and good enough for performance
causes issues and i dont think that was the culprit of the window resize lag
and icon. i know the icon is terrible i spent 30 seconds on it. ill maybe fix it later
(note: this does *not* add offline support. i dont plan on implementing song caching nor do i really want to, and i'm not even sure if large-scale song caching is possible on the web. this app requires a connection to the server to function)
mostly getting stuff out of utils and moving things to their proper modules
also added a short comment for each file
this was much more complex than i thought it would be
also moved shuffle into here as a sorting option
(if you have a queue and you update, the track/disc sorting wont work until you make a new queue since those werent saved to localstorage previously.)
(in the future i may change it so that the queue only stores song ids, and fetches all data from server on startup, instead of most track metadata to prevent hitting localstorage limits. and also get proper updates if songs change. its not like you can really use this offline anyway since we dont have track caching and i dont plan on implementing that.)
also rename queue_action to queue_play, it was named that way since i originally had one action (which was play)
didnt really make sense to have these separated in my opinion. ive also cleaned up the css heavily and change context menu to use id
- only synced lyrics show now since unsynced lyrics were broken (would just show last line instead), which i didnt think about since i dont use unsynced lyrics...
- maybe i'll add support to open a sidebar for unsynced lyrics or something in the future, if requested then sure!
- added a little optimization to not update lyrics when the document is hidden (i.e. switched to differnt tab or minimized)
- also added some comments for clarity
i stuck with spacers because vue-virtual-scroll's method of using minheight didnt really work well for tables. but this is less buggy and far cleaner
at the time of writing, this produces a 134kb single html file. this
file can be plopped on a server to use tinysub.
Signed-off-by: oppiliappan <me@oppi.li>
the js bits just load the icons from the lookup table if need be.
Signed-off-by: oppiliappan <me@oppi.li>
to prevent users from accidentally logging out and clearing all their settings and cache and blablabla
mobile users, those on very slow networks, and those on metered networks may have a bad experience with large queues. still configurable in settings of course
if we switch to svelte or some sort of framework then ill import this properly as a npm package
oh i also fixed how the "clear" action in the footer works. now its more consistent with sort, if you have a couple tracks selected it'll only delete those tracks, but if you have no selected tracks it'll delete everything.
(maybe i should also move the sort button to the queue context menu later? would be more consistent with the clear action)
and icon. i know the icon is terrible i spent 30 seconds on it. ill maybe fix it later
(note: this does *not* add offline support. i dont plan on implementing song caching nor do i really want to, and i'm not even sure if large-scale song caching is possible on the web. this app requires a connection to the server to function)
this was much more complex than i thought it would be
also moved shuffle into here as a sorting option
(if you have a queue and you update, the track/disc sorting wont work until you make a new queue since those werent saved to localstorage previously.)
(in the future i may change it so that the queue only stores song ids, and fetches all data from server on startup, instead of most track metadata to prevent hitting localstorage limits. and also get proper updates if songs change. its not like you can really use this offline anyway since we dont have track caching and i dont plan on implementing that.)
- only synced lyrics show now since unsynced lyrics were broken (would just show last line instead), which i didnt think about since i dont use unsynced lyrics...
- maybe i'll add support to open a sidebar for unsynced lyrics or something in the future, if requested then sure!
- added a little optimization to not update lyrics when the document is hidden (i.e. switched to differnt tab or minimized)
- also added some comments for clarity