package handlers import ( "context" "net/http" "net/http/httptest" "runtime" "strings" "testing" "time" "github.com/stormlightlabs/noteleaf/internal/articles" "github.com/stormlightlabs/noteleaf/internal/models" "github.com/stormlightlabs/noteleaf/internal/repo" "github.com/stormlightlabs/noteleaf/internal/shared" ) func TestArticleHandler(t *testing.T) { t.Run("NewArticleHandler", func(t *testing.T) { t.Run("creates handler successfully", func(t *testing.T) { helper := NewArticleTestHelper(t) if helper.ArticleHandler == nil { t.Fatal("Handler should not be nil") } if helper.db == nil { t.Error("Handler database should not be nil") } if helper.config == nil { t.Error("Handler config should not be nil") } if helper.repos == nil { t.Error("Handler repos should not be nil") } if helper.parser == nil { t.Error("Handler parser should not be nil") } }) t.Run("handles database initialization error", func(t *testing.T) { envHelper := NewEnvironmentTestHelper() defer envHelper.RestoreEnv() if runtime.GOOS == "windows" { envHelper.UnsetEnv("APPDATA") } else { envHelper.UnsetEnv("XDG_CONFIG_HOME") envHelper.UnsetEnv("HOME") } _, err := NewArticleHandler() shared.AssertErrorContains(t, err, "failed to initialize database", "NewArticleHandler should fail when database initialization fails") }) }) t.Run("Add", func(t *testing.T) { t.Run("adds article successfully", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) w.Write([]byte(` Test Article

Test Article Title

Test Author

2024-01-01

This is test content for the article.

`)) })) defer server.Close() testRule := &articles.ParsingRule{ Domain: "127.0.0.1", Title: "//h1[@id='firstHeading']", Author: "//div[@class='author']", Date: "//div[@class='date']", Body: "//div[@id='bodyContent']", } helper.AddTestRule("127.0.0.1", testRule) err := helper.Add(ctx, server.URL+"/test-article") shared.AssertNoError(t, err, "Add should succeed with valid URL") articles, err := helper.repos.Articles.List(ctx, &repo.ArticleListOptions{}) if err != nil { t.Fatalf("Failed to list articles: %v", err) } if len(articles) != 1 { t.Errorf("Expected 1 article, got %d", len(articles)) } article := articles[0] if article.Title != "Test Article Title" { t.Errorf("Expected title 'Test Article Title', got '%s'", article.Title) } if article.Author != "Test Author" { t.Errorf("Expected author 'Test Author', got '%s'", article.Author) } }) t.Run("handles duplicate article", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() duplicateURL := "https://example.com/duplicate" existingArticle := &models.Article{ URL: duplicateURL, Title: "Existing Article", Author: "Existing Author", Date: "2024-01-01", MarkdownPath: "/path/to/existing.md", HTMLPath: "/path/to/existing.html", Created: time.Now(), Modified: time.Now(), } _, err := helper.repos.Articles.Create(ctx, existingArticle) if err != nil { t.Fatalf("Failed to create existing article: %v", err) } err = helper.Add(ctx, duplicateURL) shared.AssertNoError(t, err, "Add should succeed with duplicate URL and return existing") }) t.Run("handles unsupported domain", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) w.Write([]byte("Test

Content

")) })) defer server.Close() err := helper.Add(ctx, server.URL+"/unsupported") shared.AssertErrorContains(t, err, "failed to parse article", "Add should fail with unsupported domain") }) t.Run("handles HTTP error", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusNotFound) })) defer server.Close() err := helper.Add(ctx, server.URL+"/404") shared.AssertErrorContains(t, err, "failed to parse article", "Add should fail with HTTP error") }) t.Run("handles storage directory error", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() envHelper := NewEnvironmentTestHelper() defer envHelper.RestoreEnv() // Unset all environment variables that could provide a storage directory envHelper.UnsetEnv("NOTELEAF_DATA_DIR") envHelper.UnsetEnv("NOTELEAF_CONFIG") if runtime.GOOS == "windows" { envHelper.UnsetEnv("USERPROFILE") envHelper.UnsetEnv("HOMEDRIVE") envHelper.UnsetEnv("HOMEPATH") envHelper.UnsetEnv("LOCALAPPDATA") } else { envHelper.UnsetEnv("HOME") envHelper.UnsetEnv("XDG_DATA_HOME") } err := helper.Add(ctx, "https://example.com/test-article") shared.AssertErrorContains(t, err, "failed to get article storage dir", "Add should fail when storage directory cannot be determined") }) t.Run("handles database save error", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) w.Write([]byte(` Test Article

Test Article

Test content

`)) })) defer server.Close() testRule := &articles.ParsingRule{ Domain: "127.0.0.1", Title: "//h1[@id='firstHeading']", Body: "//div[@id='bodyContent']", } helper.AddTestRule("127.0.0.1", testRule) helper.db.Exec("DROP TABLE articles") err := helper.Add(ctx, server.URL+"/test") shared.AssertErrorContains(t, err, "failed to save article to database", "Add should fail when database save fails") }) }) t.Run("List", func(t *testing.T) { t.Run("lists all articles", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() id1 := helper.CreateTestArticle(t, "https://example.com/article1", "First Article", "John Doe", "2024-01-01") id2 := helper.CreateTestArticle(t, "https://example.com/article2", "Second Article", "Jane Smith", "2024-01-02") err := helper.List(ctx, "", "", 0) shared.AssertNoError(t, err, "List should succeed") AssertExists(t, helper.repos.Articles.Get, id1, "article") AssertExists(t, helper.repos.Articles.Get, id2, "article") }) t.Run("lists with title filter", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() helper.CreateTestArticle(t, "https://example.com/first", "First Article", "John", "2024-01-01") helper.CreateTestArticle(t, "https://example.com/second", "Second Article", "Jane", "2024-01-02") err := helper.List(ctx, "First", "", 0) shared.AssertNoError(t, err, "List with title filter should succeed") }) t.Run("lists with author filter", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() helper.CreateTestArticle(t, "https://example.com/john1", "Article by John", "John Doe", "2024-01-01") helper.CreateTestArticle(t, "https://example.com/jane1", "Article by Jane", "Jane Smith", "2024-01-02") err := helper.List(ctx, "", "John", 0) shared.AssertNoError(t, err, "List with author filter should succeed") }) t.Run("lists with limit", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() helper.CreateTestArticle(t, "https://example.com/1", "Article 1", "Author", "2024-01-01") helper.CreateTestArticle(t, "https://example.com/2", "Article 2", "Author", "2024-01-02") helper.CreateTestArticle(t, "https://example.com/3", "Article 3", "Author", "2024-01-03") err := helper.List(ctx, "", "", 2) shared.AssertNoError(t, err, "List with limit should succeed") }) t.Run("handles empty results", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() err := helper.List(ctx, "nonexistent", "", 0) shared.AssertNoError(t, err, "List with no matches should succeed") }) t.Run("handles database error", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() helper.db.Exec("DROP TABLE articles") err := helper.List(ctx, "", "", 0) shared.AssertErrorContains(t, err, "failed to list articles", "List should fail when database is corrupted") }) }) t.Run("View", func(t *testing.T) { t.Run("views article successfully", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() id := helper.CreateTestArticle(t, "https://example.com/test", "Test Article", "Test Author", "2024-01-01") err := helper.View(ctx, id) shared.AssertNoError(t, err, "View should succeed with valid article ID") }) t.Run("handles non-existent article", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() err := helper.View(ctx, 99999) shared.AssertErrorContains(t, err, "failed to get article", "View should fail with non-existent article ID") }) t.Run("handles missing files gracefully", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() article := &models.Article{ URL: "https://example.com/missing-files", Title: "Missing Files Article", Author: "Test Author", Date: "2024-01-01", MarkdownPath: "/non/existent/path.md", HTMLPath: "/non/existent/path.html", Created: time.Now(), Modified: time.Now(), } id, err := helper.repos.Articles.Create(ctx, article) if err != nil { t.Fatalf("Failed to create article with missing files: %v", err) } err = helper.View(ctx, id) shared.AssertNoError(t, err, "View should succeed even when files are missing") }) t.Run("handles database error", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() helper.db.Exec("DROP TABLE articles") err := helper.View(ctx, 1) shared.AssertErrorContains(t, err, "failed to get article", "View should fail when database is corrupted") }) }) t.Run("Read", func(t *testing.T) { t.Run("read renders article successfully", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() id := helper.CreateTestArticle(t, "https://example.com/read", "Read Test Article", "Test Author", "2024-01-01") err := helper.Read(ctx, id) shared.AssertNoError(t, err, "Read should succeed with valid article ID") }) t.Run("handles non-existent article", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() err := helper.Read(ctx, 99999) shared.AssertErrorContains(t, err, "failed to get article", "Read should fail with non-existent article ID") }) t.Run("handles missing markdown file", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() article := &models.Article{ URL: "https://example.com/missing-md", Title: "Missing Markdown Article", Author: "Test Author", Date: "2024-01-01", MarkdownPath: "/non/existent/path.md", HTMLPath: "/some/existent/path.html", Created: time.Now(), Modified: time.Now(), } id, err := helper.repos.Articles.Create(ctx, article) if err != nil { t.Fatalf("Failed to create article with missing markdown file: %v", err) } err = helper.Read(ctx, id) shared.AssertErrorContains(t, err, "markdown file not found", "Read should fail when markdown file is missing") }) t.Run("handles database error", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() helper.db.Exec("DROP TABLE articles") err := helper.Read(ctx, 1) shared.AssertErrorContains(t, err, "failed to get article", "Read should fail when database is corrupted") }) }) t.Run("Remove", func(t *testing.T) { t.Run("removes article successfully", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() id := helper.CreateTestArticle(t, "https://example.com/remove", "Remove Test", "Author", "2024-01-01") AssertExists(t, helper.repos.Articles.Get, id, "article") err := helper.Remove(ctx, id) shared.AssertNoError(t, err, "Remove should succeed") AssertNotExists(t, helper.repos.Articles.Get, id, "article") }) t.Run("handles non-existent article", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() err := helper.Remove(ctx, 99999) shared.AssertErrorContains(t, err, "failed to get article", "Remove should fail with non-existent article ID") }) t.Run("handles missing files gracefully", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() article := &models.Article{ URL: "https://example.com/missing-files", Title: "Missing Files Article", Author: "Test Author", Date: "2024-01-01", MarkdownPath: "/non/existent/path.md", HTMLPath: "/non/existent/path.html", Created: time.Now(), Modified: time.Now(), } id, err := helper.repos.Articles.Create(ctx, article) if err != nil { t.Fatalf("Failed to create article with missing files: %v", err) } err = helper.Remove(ctx, id) shared.AssertNoError(t, err, "Remove should succeed even when files don't exist") }) t.Run("handles database error", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() id := helper.CreateTestArticle(t, "https://example.com/db-error", "DB Error Test", "Author", "2024-01-01") helper.db.Exec("DROP TABLE articles") err := helper.Remove(ctx, id) shared.AssertErrorContains(t, err, "failed to get article", "Remove should fail when database is corrupted") }) }) t.Run("Help", func(t *testing.T) { t.Run("shows supported domains", func(t *testing.T) { helper := NewArticleTestHelper(t) err := helper.Help() shared.AssertNoError(t, err, "Help should succeed") }) t.Run("handles storage directory error", func(t *testing.T) { helper := NewArticleTestHelper(t) envHelper := NewEnvironmentTestHelper() defer envHelper.RestoreEnv() // Unset all environment variables that could provide a storage directory envHelper.UnsetEnv("NOTELEAF_DATA_DIR") envHelper.UnsetEnv("NOTELEAF_CONFIG") if runtime.GOOS == "windows" { envHelper.UnsetEnv("USERPROFILE") envHelper.UnsetEnv("HOMEDRIVE") envHelper.UnsetEnv("HOMEPATH") envHelper.UnsetEnv("LOCALAPPDATA") } else { envHelper.UnsetEnv("HOME") envHelper.UnsetEnv("XDG_DATA_HOME") } err := helper.Help() shared.AssertErrorContains(t, err, "failed to get storage directory", "Help should fail when storage directory cannot be determined") }) }) t.Run("Close", func(t *testing.T) { t.Run("closes successfully", func(t *testing.T) { helper := NewArticleTestHelper(t) err := helper.Close() shared.AssertNoError(t, err, "Close should succeed") }) t.Run("handles nil database gracefully", func(t *testing.T) { helper := NewArticleTestHelper(t) helper.db = nil err := helper.Close() shared.AssertNoError(t, err, "Close should succeed with nil database") }) }) t.Run("getStorageDirectory", func(t *testing.T) { t.Run("returns storage directory successfully", func(t *testing.T) { helper := NewArticleTestHelper(t) dir, err := helper.getStorageDirectory() shared.AssertNoError(t, err, "getStorageDirectory should succeed") if dir == "" { t.Error("Storage directory should not be empty") } if !strings.Contains(dir, "articles") { t.Errorf("Expected storage directory to contain 'articles', got: %s", dir) } }) t.Run("handles user home directory error", func(t *testing.T) { helper := NewArticleTestHelper(t) envHelper := NewEnvironmentTestHelper() defer envHelper.RestoreEnv() // Unset NOTELEAF_DATA_DIR to force GetDataDir to use OS-specific variables envHelper.UnsetEnv("NOTELEAF_DATA_DIR") switch runtime.GOOS { case "windows": envHelper.UnsetEnv("LOCALAPPDATA") envHelper.UnsetEnv("APPDATA") case "darwin": envHelper.UnsetEnv("HOME") default: envHelper.UnsetEnv("XDG_DATA_HOME") envHelper.UnsetEnv("HOME") } _, err := helper.getStorageDirectory() shared.AssertErrorContains(t, err, "", "getStorageDirectory should fail when home directory cannot be determined") }) }) } func TestArticleHandlerIntegration(t *testing.T) { t.Run("end-to-end workflow", func(t *testing.T) { helper := NewArticleTestHelper(t) ctx := context.Background() server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) w.Write([]byte(` Integration Test Article

Integration Test Article

Integration Author

Integration test content.

`)) })) defer server.Close() testRule := &articles.ParsingRule{ Domain: "127.0.0.1", Title: "//h1[@id='firstHeading']", Author: "//div[@class='author']", Body: "//div[@id='bodyContent']", } helper.AddTestRule("127.0.0.1", testRule) err := helper.Add(ctx, server.URL+"/integration-test") shared.AssertNoError(t, err, "Add should succeed in integration test") err = helper.List(ctx, "", "", 0) shared.AssertNoError(t, err, "List should succeed in integration test") articles, err := helper.repos.Articles.List(ctx, &repo.ArticleListOptions{}) if err != nil { t.Fatalf("Failed to get articles for integration test: %v", err) } if len(articles) == 0 { t.Fatal("Expected at least one article for integration test") } articleID := articles[0].ID err = helper.View(ctx, articleID) shared.AssertNoError(t, err, "View should succeed in integration test") err = helper.Help() shared.AssertNoError(t, err, "Help should succeed in integration test") err = helper.Remove(ctx, articleID) shared.AssertNoError(t, err, "Remove should succeed in integration test") AssertNotExists(t, helper.repos.Articles.Get, articleID, "article") }) }