pneumo

M4: Fix download notification Share (ENG-270) #32

Merged

demi.dev 1w ago

targeting main from stoopkidddd/eng-270-fix-download-notification-share

Merged opened by and assigned to

demi.dev 1w ago targeting main from stoopkidddd/eng-270-fix-download-notification-share

Linear: https://linear.app/engineereddev/issue/ENG-270 (M4 gate; bug from ENG-266)

The M4 gate's release-build run found that Share on the download-complete notification did nothing: the ACTION_CHOOSER wrapper carried a pneumo://download/share data URI (for PendingIntent identity), so it resolved to no activity (ActivityNotFoundException in SystemUI). Home's Share worked.

What's in this PR (7 files):

New non-exported, no-display trampoline notify/DownloadShareActivity (taskAffinity="", noHistory, excludeFromRecents), mirroring DownloadOpenActivity. The notification's Share PendingIntent targets it with the file's content URI and MIME as intent data/type (per-notification identity); it starts a data-free system chooser for that file and finishes. Only content:// URIs are accepted.
DownloadActions.kt: Share PendingIntent built for the trampoline. Notification ids/tags, group/summary rules and the progress throttle are unchanged.
Tests: DownloadActionsTest (fails on the old code on API 26 and 34: the Share intent resolves; two files get two distinct Share targets); RealServerSmokeTest now fires the completed notification's real Share PendingIntent and checks the chooser's file URI, MIME, clip data and read grant.
docs/SPEC.md §14.2: one sentence noting the two library-merged permissions (WAKE_LOCK from WorkManager, the signature-level DYNAMIC_RECEIVER_NOT_EXPORTED_PERMISSION from androidx.core), found by the gate's merged-manifest check.

Verify (lead, on 0261414):

mise run check:android → exit 0
./gradlew testDebugUnitTest --rerun → exit 0 (355 tests, 0 failures)
mise run e2e:android → exit 0 (real-server smoke incl. Share; secret scan 0 matches; full cleanup)

🤖 Generated with Claude Code

Commits 1

M4: Fix download notification Share (ENG-270)

+122 -15

Comments

v0 1w ago

demi.dev 1w ago

pneumo-reviewer: round 1, APPROVE #

The fix is correct and in scope. Share targets a non-exported, no-display trampoline (DownloadShareActivity) whose intent carries the file's content URI and MIME; it starts a data-free chooser, which resolves. Each notification keeps its own Share PendingIntent (action, component and data differ from Open and from other files).

Tests break correctly: the old code fails 3 of 5 (assertNull on chooser data, API 26 and 34); the "just drop the data" version fails 2 of 5 (the collision assertNotEquals). The smoke's Share step (exerciseFileShare) times out on the old code.
Trampoline safety OK: exported=false, taskAffinity="", noHistory, excludeFromRecents, NoDisplay, immutable PendingIntent, accepts only ACTION_SEND + content:// + MIME, read grant for that URI only.
ENG-263/266/268 invariants unchanged. The §14.2 sentence matches the manifest-merger report and is the only SPEC change.
Suggestion: tap Share once by hand from a real shade on the release build (ATD fires the PendingIntent in-process). Added to ENG-274's real-device checklist.

FILE (score < 5, recorded on ENG-275)

score=4 — the trampoline starts the chooser without FLAG_ACTIVITY_NEW_TASK, inside an excludeFromRecents task (same as DownloadOpenActivity); a share target may be hard to return to from Recents.
score=2 — DownloadActionsTest:89 resolveActivity passes under Robolectric even without the manifest entry; use getActivityInfo.

Verify (reviewer and lead): check:android exit 0; testDebugUnitTest --rerun 355/0 failures; mise run e2e:android exit 0 (Share chooser verified; secret scan 0 matches).

Versions

pneumo-reviewer: round 1, APPROVE #