Invalid ResourceLocation Generated for Biome Bottle (Infinity 2.7.0+1.20.1‑tb6) #8

Open ruen.tngl.sh
Open opened by ruen.tngl.sh

Version:
Infinite Dimensions 2.7.0+1.20.1-tb6
Minecraft 1.20.1
Forge 47.4.10

Description:
Causing a hover tooltip causes a crash when Infinite Dimensions attempts to render a Biome Bottle whose internal biome ID is malformed. Infinity constructs an invalid ResourceLocation containing two namespaces, which Minecraft rejects.

From the crash report:

Non [a-z0-9/._-] character in path of location: infinity:minecraft:old_growth_pine_taiga

This is not a valid ResourceLocation. Expected format:

minecraft:old_growth_pine_taiga

Actual output from Infinity:

infinity:minecraft:old_growth_pine_taiga

This triggers a ResourceLocationException during tooltip rendering.


Steps to Reproduce #

  1. Install Infinite Dimensions 2.7.0+1.20.1‑tb6.
  2. Obtain a Biome Bottle containing the biome minecraft:old_growth_pine_taiga (likely others too).
  3. Open the inventory and hover over an item to produce a tooltip.
  4. Game crashes immediately.

Expected Behavior #

Infinity should return a valid biome ID:

minecraft:old_growth_pine_taiga

Actual Behavior #

Infinity prepends its own namespace incorrectly, producing:

infinity:minecraft:old_growth_pine_taiga

This causes:

net.minecraft.ResourceLocationException: Non [a-z0-9/._-] character in path of location

Relevant Stack Trace #

net.minecraft.ResourceLocationException: Non [a-z0-9/._-] character in path of location: infinity:minecraft:old_growth_pine_taiga
    at net.minecraft.resources.ResourceLocation.<init>(ResourceLocation.java:40)
    at net.lerariemann.infinity.util.VersionMethods.id(VersionMethods.java:83)
    at net.lerariemann.infinity.util.InfinityMethods.getId(InfinityMethods.java:69)
    at net.lerariemann.infinity.util.VersionMethods.getBiomeComponents(VersionMethods.java:291)
    at net.lerariemann.infinity.item.BiomeBottleItem.m_7373_(BiomeBottleItem.java:48)

Suspected Cause #

VersionMethods.id() incorrectly concatenates namespaces when generating biome component IDs.

Addnt'l Note #

When viewing the item entity on the ground using Jade, the detail (expanded) view that would normally show the item tooltip says <Error occurred, plz report to Infinite Dimensions>

Sign up or Sign in to add to the discussion.