bad-example.com
commits
this probably either does too much or too little:
- could have fixed the double-slash thing by stripping trailing slash from the base uri or,
- if you like typed URLs, it probably makes sense to do a bigger refactor toward them.
...sidestepping adding the actual `url` dependency by using the one included with `reqwest`. maybe this is not what you want.
currently using `EncodeError::Other` instead of adding a variant to `EncodeError` itself because the parse error comes from `Url`, which we snuck in from `reqwest`, which isn't a dependency of the `-common` crate.
opting to just...not be compatible with the old untyped blobrefs to simplify.
haven't seen those in the wild ever afaik.
might swap to a custom Serialize/Deserialize impl to get that capability without
a bunch of extra nesting.
this probably either does too much or too little:
- could have fixed the double-slash thing by stripping trailing slash from the base uri or,
- if you like typed URLs, it probably makes sense to do a bigger refactor toward them.
...sidestepping adding the actual `url` dependency by using the one included with `reqwest`. maybe this is not what you want.
currently using `EncodeError::Other` instead of adding a variant to `EncodeError` itself because the parse error comes from `Url`, which we snuck in from `reqwest`, which isn't a dependency of the `-common` crate.