tg
An unofficial terminal client for Tangled, optimized for humans and agents. tgcli.wisp.place
cli atproto go tangled
Star 329
Fork 10
Watch

pr comment: created comments do not appear on PR pages in the web UI #89

Closed sullen.net
Closed opened by sullen.net

Running tg pr comment <rkey> --body "..." on v0.9.0 succeeds and writes an org.tangled.feed.comment record to the knot, but the comment doesn't show up in the PR discussion thread on tangled.org (and doesn't increment commentCount in tg pr list).

Comparing a comment created from the web UI against one created by tg pr comment, the main difference appears to be the subject strongRef:

  • tg pr comment sets subject to the latest org.tangled.review.patch record (at://<repo-did>/org.tangled.review.patch/<cid>).
  • The web UI sets subject to the PR's org.tangled.track.ticket record (at://<repo-did>/org.tangled.track.ticket/<rkey>), which is also what the PR page queries via org.tangled.feed.listComments.

Not sure whether tg should be targeting org.tangled.track.ticket directly (like CommentIssue does) or if org.tangled.review.patch comments are meant to be surfaced differently by the appview/web UI, so wanted to flag it here.

aly.codes

thank you! This helps, it should be fixed now 😃 lots of changes happened with the new lexicons, it’s been a lot to sort through.

sullen.net

thank u for the tool :-)

Sign up or Sign in to add to the discussion.